From c60991870ec167483b566b78f2163c00df18b63c Mon Sep 17 00:00:00 2001 From: Ivy Jian Date: Tue, 11 Feb 2025 15:53:29 +0800 Subject: [PATCH] mb/google/nissa/var/dirks: Use a separate ec.h for dirks Dirks are chromebox, so they need different settings in ec.h. Add a new dirks baseboard ec.h and use it for dirks.Remove everything related to: - Lid - Battery - Built-in keyboard - AC connect/disconnect - Mode changes BUG=b:389391653 TEST=emerge-nissa coreboot Change-Id: I8089a2aff3032a4271212765f65881a09f42c1ae Signed-off-by: Ivy Jian Reviewed-on: https://review.coreboot.org/c/coreboot/+/86354 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- .../nissa/include/baseboard/dirks/ec.h | 44 +++++++++++++++++++ .../brya/variants/dirks/include/variant/ec.h | 2 +- 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h new file mode 100644 index 0000000000..d9697d7c3c --- /dev/null +++ b/src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/dirks/ec.h @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __BASEBOARD_EC_H__ +#define __BASEBOARD_EC_H__ + +#include +#include +#include + +#define MAINBOARD_EC_SCI_EVENTS \ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX)) +#define MAINBOARD_EC_SMI_EVENTS 0 +/* EC can wake from S5 with power button */ +#define MAINBOARD_EC_S5_WAKE_EVENTS \ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON)) +/* EC can wake from S3 with power button */ +#define MAINBOARD_EC_S3_WAKE_EVENTS (MAINBOARD_EC_S5_WAKE_EVENTS) +#define MAINBOARD_EC_S0IX_WAKE_EVENTS \ + (MAINBOARD_EC_S3_WAKE_EVENTS |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_HANG_DETECT)) +/* Log EC wake events plus EC shutdown events */ +#define MAINBOARD_EC_LOG_EVENTS \ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_SHUTDOWN) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC)) +/* + * ACPI related definitions for ASL code. + */ +/* Enable cros_ec_keyb device */ +#define EC_ENABLE_MKBP_DEVICE +#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE +/* Enable EC backed PD MCU device in ACPI */ +#define EC_ENABLE_PD_MCU_DEVICE +#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ +#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ + +#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp support */ + +#endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brya/variants/dirks/include/variant/ec.h b/src/mainboard/google/brya/variants/dirks/include/variant/ec.h index 7a2a6ff8b7..469e75c834 100644 --- a/src/mainboard/google/brya/variants/dirks/include/variant/ec.h +++ b/src/mainboard/google/brya/variants/dirks/include/variant/ec.h @@ -3,6 +3,6 @@ #ifndef __VARIANT_EC_H__ #define __VARIANT_EC_H__ -#include +#include #endif