erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/rex: Add IPUA device and sensor names

Browse source 
Add missing configuration items for rex variants to have functional
MIPI cameras under Windows/mainline Linux:

- Add IPUA device to graphics device configuration
- Add sensor_name register to sensor device configurations

Screebo was missing the gfx/generic configuration for all other display
outputs present in other variants, so add that as well.

TEST=build/boot Win11/Linux on karis and screebo, verify MIPI camera
functional under both OSes using the standard driver stack.

Change-Id: I14ec0efd88c43ca94ebde2be4652775bcb6d73c3
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90573
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
Matt DeVillier 2025-12-19 18:06:56 -06:00
commit c5eecee5e9
4 changed files with 51 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/mainboard/google/rex/variants/kanix/overridetree.cb
View file

@ -152,7 +152,7 @@ chip soc/intel/meteorlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "6"
register "device_count" = "7"
# DDIA for eDP
register "device[0].name" = ""LCD0""
register "device[0].type" = "panel"
@ -170,6 +170,11 @@ chip soc/intel/meteorlake
register "device[4].pld" = "ACPI_PLD_TYPE_C(LEFT, RIGHT, ACPI_PLD_GROUP(2, 1))"
# TCP3 (DP-4) unused
register "device[5].name" = ""DD05""
# IPUA for IPUs
register "device[6].name" = ""IPUA""
register "device[6].non_vga_device" = "true"
register "device[6].addr" = "0x3480"
device generic 0 on end
end
end # Integrated Graphics Device
@ -505,6 +510,7 @@ chip soc/intel/meteorlake
register "acpi_uid" = "0"
register "acpi_name" = ""CAM0""
register "chip_name" = ""Hi-556 Camera""
register "sensor_name" = ""CJFLE25""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "has_power_resource" = "true"

7
src/mainboard/google/rex/variants/karis/overridetree.cb
View file

@ -130,7 +130,7 @@ chip soc/intel/meteorlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "6"
register "device_count" = "7"
# DDIA for eDP
register "device[0].name" = ""LCD0""
register "device[0].type" = "panel"
@ -148,6 +148,10 @@ chip soc/intel/meteorlake
register "device[4].pld" = "ACPI_PLD_TYPE_C(LEFT, RIGHT, ACPI_PLD_GROUP(2, 1))"
# TCP3 (DP-4) unused
register "device[5].name" = ""DD05""
# IPUA for IPUs
register "device[6].name" = ""IPUA""
register "device[6].non_vga_device" = "true"
register "device[6].addr" = "0x3480"
device generic 0 on end
end
end # Integrated Graphics Device
@ -460,6 +464,7 @@ chip soc/intel/meteorlake
register "acpi_uid" = "0"
register "acpi_name" = ""CAM0""
register "chip_name" = ""Hi-556 Camera""
register "sensor_name" = ""CJFLE25""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "has_power_resource" = "true"

9
src/mainboard/google/rex/variants/rex0/overridetree.cb
View file

@ -148,7 +148,7 @@ chip soc/intel/meteorlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "6"
register "device_count" = "7"
# DDIA for eDP
register "device[0].name" = ""LCD0""
register "device[0].type" = "panel"
@ -167,6 +167,11 @@ chip soc/intel/meteorlake
register "device[4].pld" = "ACPI_PLD_TYPE_C(RIGHT, LEFT, ACPI_PLD_GROUP(2, 1))"
# TCP3 (DP-4) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP3
register "device[5].name" = ""DD05""
# IPUA for IPUs
register "device[6].name" = ""IPUA""
register "device[6].non_vga_device" = "true"
register "device[6].addr" = "0x3480"
device generic 0 on end
end
end # Integrated Graphics Device
@ -466,6 +471,7 @@ chip soc/intel/meteorlake
register "acpi_uid" = "0"
register "acpi_name" = ""CAM0""
register "chip_name" = ""Ov 13b10 Camera""
register "sensor_name" = ""09B13U""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "4"
@ -623,6 +629,7 @@ chip soc/intel/meteorlake
register "acpi_uid" = "0"
register "acpi_name" = ""CAM1""
register "chip_name" = ""Hi-556 Camera""
register "sensor_name" = ""CJFLE25""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "has_power_resource" = "true"

30
src/mainboard/google/rex/variants/screebo/overridetree.cb
View file

@ -152,6 +152,35 @@ chip soc/intel/meteorlake
}"
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "7"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0
register "device[2].name" = ""DD02""
register "device[2].use_pld" = "true"
register "device[2].pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
# TCP1 (DP-2) is unused for any ports but still enumerated in the kernel
register "device[3].name" = ""DD03""
# TCP2 (DP-3) for port C1
register "device[4].name" = ""DD04""
register "device[4].use_pld" = "true"
register "device[4].pld" = "ACPI_PLD_TYPE_C(RIGHT, RIGHT, ACPI_PLD_GROUP(2, 1))"
# TCP3 (DP-4) is unused for any ports but still enumerated in the kernel
register "device[5].name" = ""DD05""
# IPUA for IPUs
register "device[6].name" = ""IPUA""
register "device[6].non_vga_device" = "true"
register "device[6].addr" = "0x3480"
device generic 0 on end
end
end # Integrated Graphics Device
device ref dtt on
chip drivers/intel/dptf
## sensor information
@ -513,6 +542,7 @@ chip soc/intel/meteorlake
register "acpi_uid" = "0"
register "acpi_name" = ""CAM0""
register "chip_name" = ""Ov 08X40 Camera""
register "sensor_name" = ""CJFME55""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "4"