soc/intel/elkhartlake/pmc,gpio: Fix PMC GPE GPIO routes

Based on the description of PMC GPIO_CONF register from
EHL EDS Vol 2 Book 2 rev 2.3 #614109.

Some of the groups had incorrect values or even defined
non-existent GPIO groups.

TEST=Boot Protectli VP2420 to Ubuntu 24.04.

Change-Id: I910f3c4c0d31b8d24b83cd2c3a28688b898b5d9f
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87050
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>

src/soc/intel/elkhartlake/gpio.c

@@ -226,7 +226,6 @@ const struct pmc_to_gpio_route *soc_pmc_gpio_routes(size_t *num)
 		{ PMC_GPP_C, GPP_C },
 		{ PMC_GPP_E, GPP_E },
 		{ PMC_GPP_G, GPP_G },
-		{ PMC_GPP_S, GPP_S }
 	};
 
 	*num = ARRAY_SIZE(routes);

src/soc/intel/elkhartlake/include/soc/gpio_soc_defs.h

@@ -10,19 +10,18 @@
  */
 #define GPP_B			0x0
 #define GPP_T			0x1
-#define GPP_D			0x2
-#define GPP_A			0x3
-#define GPP_R			0x4
+#define GPP_A			0x2
+#define GPP_R			0x3
+#define GPD			0x4
 #define GPP_V			0x5
-#define GPD			0x6
-#define GPP_H			0x7
+#define GPP_H			0x6
+#define GPP_D			0x7
 #define GPP_U			0x8
 #define VGPIO			0x9
 #define GPP_F			0xA
 #define GPP_C			0xB
 #define GPP_E			0xC
 #define GPP_G			0xD
-#define GPP_S			0xE
 
 #define GPIO_NUM_GROUPS		15
 #define GPIO_MAX_NUM_PER_GROUP	32

src/soc/intel/elkhartlake/include/soc/pmc.h

@@ -105,19 +105,18 @@
 
 #define PMC_GPP_B				0x0
 #define PMC_GPP_T				0x1
-#define PMC_GPP_D				0x2
-#define PMC_GPP_A				0x3
-#define PMC_GPP_R				0x4
+#define PMC_GPP_A				0x2
+#define PMC_GPP_R				0x3
+#define PMC_GPD					0x4
 #define PMC_GPP_V				0x5
-#define PMC_GPD					0x6
-#define PMC_GPP_H				0x7
+#define PMC_GPP_H				0x6
+#define PMC_GPP_D				0x7
 #define PMC_GPP_U				0x8
 #define PMC_VGPIO				0x9
 #define PMC_GPP_F				0xA
 #define PMC_GPP_C				0xB
 #define PMC_GPP_E				0xC
 #define PMC_GPP_G				0xD
-#define PMC_GPP_S				0xE
 
 #define GBLRST_CAUSE0			0x1924
 #define   GBLRST_CAUSE0_THERMTRIP	(1 << 5)