erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pit: Stop calling tps65090 functions until we can call through the EC.

Browse source 
On pit, the tps65090 is connected to the EC and has to be accessed by proxy.
Until we have that implemented, this change removes calls to tps69050 which
will never succeed, and stops compiling in the driver.

BUG=chrome-os-partner:19420
TEST=Built and booted on pit and saw that error spew from trying to access the
tps69050 we away.
BRANCH=None

Change-Id: I409339b283b1516a52efefdcbd1f20cc8f4c2154
Signed-off-by: Gabe Black <gabeblack@google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/59238
Reviewed-by: Stefan Reinauer <reinauer@google.com>
Tested-by: Gabe Black <gabeblack@chromium.org>
Commit-Queue: Gabe Black <gabeblack@chromium.org>
This commit is contained in:
Gabe Black 2013-06-19 02:10:36 -07:00 • committed by ChromeBot
commit c366f5f488
2 changed files with 2 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/mainboard/google/pit/Kconfig
View file

@ -29,7 +29,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_4096
select DRIVER_MAXIM_MAX77686
select CHROMEOS
select DRIVER_TI_TPS65090
select MAINBOARD_HAS_NATIVE_VGA_INIT
select MAINBOARD_DO_NATIVE_VGA_INIT
select HAVE_INIT_TIMER

26
src/mainboard/google/pit/mainboard.c
View file

@ -20,7 +20,6 @@
#include <console/console.h>
#include <device/device.h>
#include <device/i2c.h>
#include <drivers/ti/tps65090/tps65090.h>
#include <cbmem.h>
#include <delay.h>
#include <edid.h>
@ -126,24 +125,6 @@ static void backlight_en(void)
gpio_direction_output(GPIO_X30, 1);
}
#define TPS69050_BUS 4 /* Pit-specific */
#define FET1_CTRL 0x0f
#define FET6_CTRL 0x14
static void lcd_vdd(void)
{
/* Enable FET6, lcd panel */
tps65090_fet_enable(TPS69050_BUS, FET6_CTRL);
}
static void backlight_vdd(void)
{
/* Enable FET1, backlight */
tps65090_fet_enable(TPS69050_BUS, FET1_CTRL);
udelay(LCD_T5_DELAY_MS * 1000);
}
//static struct video_info smdk5420_dp_config = {
static struct video_info dp_video_info = {
/* FIXME: fix video_info struct to use const for name */
@ -186,9 +167,6 @@ static void mainboard_init(device_t dev)
};
void *fb_addr;
i2c_init(TPS69050_BUS, I2C_0_SPEED, I2C_SLAVE);
i2c_init(7, I2C_0_SPEED, I2C_SLAVE);
tmu_init(&exynos5420_tmu_info);
/* Clock Gating all the unused IP's to save power */
@ -200,7 +178,7 @@ static void mainboard_init(device_t dev)
fb_addr = cbmem_find(CBMEM_ID_CONSOLE);
set_vbe_mode_info_valid(&edid, (uintptr_t)fb_addr);
lcd_vdd();
// XXX Turn on the LCD power here.
// FIXME: should timeout
do {
@ -220,7 +198,7 @@ static void mainboard_init(device_t dev)
udelay(LCD_T3_DELAY_MS * 1000);
backlight_vdd();
// XXX Turn on the backlight power here.
backlight_pwm();
backlight_en();
/* if we're here, we're successful */