From c278be512b6e8045446ce80a5fc846dbd52b643f Mon Sep 17 00:00:00 2001 From: jamie_chen Date: Thu, 6 Mar 2025 09:23:29 +0800 Subject: [PATCH] mb/google/trulo/var/uldrenite: Adjust Touchpad I2C timing Adjust I2C/data fall Time to 13.5 ns and I2C data hold time to 353 ns BUG=b:397150937 BRANCH=firmware-trulo-15217.771.B TEST=Confirm the measured waveform of the Touchpad . Change-Id: I16a9967f7e99892f2aa337ad9290252ab63a5b97 Signed-off-by: jamie_chen Reviewed-on: https://review.coreboot.org/c/coreboot/+/86743 Reviewed-by: Kapil Porwal Reviewed-by: Eric Lai Reviewed-by: Dtrain Hsu Tested-by: build bot (Jenkins) --- .../brya/variants/uldrenite/overridetree.cb | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mainboard/google/brya/variants/uldrenite/overridetree.cb b/src/mainboard/google/brya/variants/uldrenite/overridetree.cb index 5571fe7902..e8ffc6072b 100644 --- a/src/mainboard/google/brya/variants/uldrenite/overridetree.cb +++ b/src/mainboard/google/brya/variants/uldrenite/overridetree.cb @@ -150,12 +150,15 @@ chip soc/intel/alderlake } }, .i2c[1] = { - .speed = I2C_SPEED_FAST, - .speed_config[0] = { - .speed = I2C_SPEED_FAST, - .scl_lcnt = 158, - .scl_hcnt = 79, - .sda_hold = 7, + .speed = I2C_SPEED_FAST, + .rise_time_ns = 200, + .fall_time_ns = 150, + .data_hold_time_ns = 950, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 166, + .scl_hcnt = 83, + .sda_hold = 35, } }, .i2c[5] = {