erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: nb/intel/i945: Fix SPD dumps

Browse source 
Currently the `break` further down is called unconditionally as the
brackets for the body of the if statement are missing. Add those.

BUG=none
BRANCH=none
TEST=none

Change-Id: I738178ea9f4f92fad237cfec23acad6af17995dd
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: b45bbb253f
Original-Change-Id: I34917a9877dcc882d880dedea689e1d72fe52888
Original-Found-by: Coverity (CID 1372941:  Control flow issues  (UNREACHABLE))
Original-Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Original-Reviewed-on: https://review.coreboot.org/18971
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Original-Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/459504
This commit is contained in:
Paul Menzel 2017-03-24 16:17:16 +01:00 • committed by chrome-bot
commit c256a420f0
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/northbridge/intel/i945/debug.c
View file

@ -87,9 +87,10 @@ void dump_spd_registers(void)
if ((i % 16) == 0)
printk(BIOS_DEBUG, "\n%02x: ", i);
status = smbus_read_byte(device, i);
if (status < 0)
if (status < 0) {
printk(BIOS_DEBUG, "bad device: %02x\n", -status);
break;
}
printk(BIOS_DEBUG, "%02x ", status);
}
device++;