From c1735c3377163aeb9e90155cb9f081a1eea919c9 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Wed, 6 Aug 2014 14:28:52 -0500 Subject: [PATCH] chromeec: correct response length for VBNV write The EC doesn't return any data when one performs a write to VBNV context. Therefore there is a mismatch of expectations. Correct this by properly setting the expected response length. BUG=chrome-os-partner:31148 BRANCH=None TEST=No longer hanging while writing to VBNV on ryu. Change-Id: I455724f20f5442bd62a792f09273227417475f07 Signed-off-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/211137 Reviewed-by: Stefan Reinauer Reviewed-by: Tom Warren Reviewed-by: Furquan Shaikh --- src/ec/google/chromeec/ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 320109e597..9deb046bc7 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -195,7 +195,7 @@ int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len) cec_cmd.cmd_data_in = &cmd_vbnvcontext; cec_cmd.cmd_data_out = &rsp_vbnvcontext; cec_cmd.cmd_size_in = sizeof(cmd_vbnvcontext); - cec_cmd.cmd_size_out = sizeof(rsp_vbnvcontext); + cec_cmd.cmd_size_out = is_read ? sizeof(rsp_vbnvcontext) : 0; cmd_vbnvcontext.op = is_read ? EC_VBNV_CONTEXT_OP_READ : EC_VBNV_CONTEXT_OP_WRITE;