include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
parent
f4c496d3e3
commit
bfb11bec3b
236 changed files with 239 additions and 240 deletions
|
|
@ -3,5 +3,5 @@
|
|||
#include <device/device.h>
|
||||
|
||||
struct chip_operations cpu_amd_pi_00730F01_ops = {
|
||||
CHIP_NAME("AMD CPU Family 16h Model 30h-3Fh")
|
||||
.name = "AMD CPU Family 16h Model 30h-3Fh",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -364,5 +364,5 @@ void generate_cpu_entries(const struct device *device)
|
|||
}
|
||||
|
||||
struct chip_operations cpu_intel_haswell_ops = {
|
||||
CHIP_NAME("Intel Haswell CPU")
|
||||
.name = "Intel Haswell CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -277,5 +277,5 @@ static const struct cpu_driver driver __cpu_driver = {
|
|||
};
|
||||
|
||||
struct chip_operations cpu_intel_model_1067x_ops = {
|
||||
CHIP_NAME("Intel Penryn CPU")
|
||||
.name = "Intel Penryn CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -242,5 +242,5 @@ void generate_cpu_entries(const struct device *device)
|
|||
}
|
||||
|
||||
struct chip_operations cpu_intel_model_2065x_ops = {
|
||||
CHIP_NAME("Intel Arrandale CPU")
|
||||
.name = "Intel Arrandale CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -380,5 +380,5 @@ void generate_cpu_entries(const struct device *device)
|
|||
}
|
||||
|
||||
struct chip_operations cpu_intel_model_206ax_ops = {
|
||||
CHIP_NAME("Intel SandyBridge/IvyBridge CPU")
|
||||
.name = "Intel SandyBridge/IvyBridge CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -3,5 +3,5 @@
|
|||
#include <device/device.h>
|
||||
|
||||
struct chip_operations cpu_intel_slot_1_ops = {
|
||||
CHIP_NAME("Slot 1 CPU")
|
||||
.name = "Slot 1 CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -16,5 +16,5 @@ static const struct cpu_driver driver __cpu_driver = {
|
|||
};
|
||||
|
||||
struct chip_operations cpu_power8_qemu_ops = {
|
||||
CHIP_NAME("POWER9 CPU")
|
||||
.name = "POWER9 CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -21,5 +21,5 @@ static const struct cpu_driver driver __cpu_driver = {
|
|||
};
|
||||
|
||||
struct chip_operations cpu_power8_qemu_ops = {
|
||||
CHIP_NAME("QEMU POWER8 CPU")
|
||||
.name = "QEMU POWER8 CPU",
|
||||
};
|
||||
|
|
|
|||
|
|
@ -22,5 +22,5 @@ static const struct cpu_driver driver __cpu_driver = {
|
|||
};
|
||||
|
||||
struct chip_operations cpu_qemu_x86_ops = {
|
||||
CHIP_NAME("QEMU x86 CPU")
|
||||
.name = "QEMU x86 CPU",
|
||||
};
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue