From bf5414f4ea44e71918406b2590f756059af0a296 Mon Sep 17 00:00:00 2001 From: Mart Raudsepp Date: Wed, 13 Aug 2008 17:21:09 +0000 Subject: [PATCH] artecgroup/dbe62: Fix SPD_NUM_COLUMNS value (DIMM page size) This changes SPD_NUM_COLUMNS from 0x8 back to 0xa, as it was originally when copied over from another board, because 0x8 evaluates to 2kB, not 8kB, while 0xa does the latter. 8kB is what the chip has and what is also set in our currently used firmwares for DBE62. This (combined with all the previous committed hard work from Ron before) fixes memtest86+ freezes and hard reboots for me in quick 30 minute testing time, while before it would freeze or reboot just into 50% of first test. There is more to do to get the optimum RAM setup, but this should do for now - the rest is just optimizing to quicker timings, while current ones in the fake SPD are very conservative. Signed-off-by: Mart Raudsepp Acked-by: Carl-Daniel Hailfinger Acked-by: Ronald G. Minnich git-svn-id: svn://coreboot.org/repository/coreboot-v3@757 f3766cd6-281f-0410-b1cd-43a5c92072e9 --- mainboard/artecgroup/dbe62/initram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mainboard/artecgroup/dbe62/initram.c b/mainboard/artecgroup/dbe62/initram.c index 97a63a5a42..186f27821a 100644 --- a/mainboard/artecgroup/dbe62/initram.c +++ b/mainboard/artecgroup/dbe62/initram.c @@ -65,7 +65,7 @@ static const struct spd_entry spd_table[] = { {SPD_tRP, 0x58}, {SPD_PRIMARY_SDRAM_WIDTH, 8}, {SPD_NUM_BANKS_PER_SDRAM, 0x4}, - {SPD_NUM_COLUMNS, 0x8}, + {SPD_NUM_COLUMNS, 0xa}, /* 8kB */ {SPD_NUM_DIMM_BANKS, 0x1}, {SPD_REFRESH, 0x82}, {SPD_SDRAM_CYCLE_TIME_2ND, 0x0},