erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: soc/intel/apollolake: Fix position of storage class

Browse source 
Fix the following error and warning detected by checkpatch.pl:

ERROR: inline keyword should sit between storage class and type
WARNING: storage class should be at the beginning of the declaration

TEST=Build for reef

Change-Id: Ie77611f00d3eda395c8f3f3a1ce8e130949bfd9e
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 2d154e8213
Original-Change-Id: I2ed418cc3b4a989eb1101013944169429bf147c2
Original-Signed-off-by: Lee Leahy <leroy.p.leahy@intel.com>
Original-Reviewed-on: https://review.coreboot.org/18726
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Philippe Mathieu-Daud <philippe.mathieu.daude@gmail.com>
Original-Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/454567
This commit is contained in:
Lee Leahy 2017-03-09 10:38:09 -08:00 • committed by chrome-bot
commit bec2b61dce
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/soc/intel/apollolake/bootblock/bootblock.c
View file

@ -49,7 +49,7 @@ static void enable_cmos_upper_bank(void)
iosf_write(IOSF_RTC_PORT_ID, RTC_CONFIG, reg);
}
void asmlinkage bootblock_c_entry(uint64_t base_timestamp)
asmlinkage void bootblock_c_entry(uint64_t base_timestamp)
{
device_t dev = NB_DEV_ROOT;

4
src/soc/intel/apollolake/include/soc/iosf.h
View file

@ -30,12 +30,12 @@ static inline void *iosf_address(uint16_t port, uint16_t reg)
return (void *)addr;
}
inline static void iosf_write(uint16_t port, uint16_t reg, uint32_t val)
static inline void iosf_write(uint16_t port, uint16_t reg, uint32_t val)
{
write32(iosf_address(port, reg), val);
}
inline static uint32_t iosf_read(uint16_t port, uint16_t reg)
static inline uint32_t iosf_read(uint16_t port, uint16_t reg)
{
return read32(iosf_address(port, reg));
}