From bd73d0ddf08b84f9775ff71eb1ddc10a30ea0a22 Mon Sep 17 00:00:00 2001 From: Naresh G Solanki Date: Wed, 12 Apr 2017 20:15:53 +0530 Subject: [PATCH] UPSTREAM: sb/intel/common/firmware: Keep CHECK_ME disabled by default While building poppy board, build failed with following error message: Writing new image to build/coreboot.pre.new mv build/coreboot.pre.new build/coreboot.pre util/me_cleaner/me_cleaner.py -c build/coreboot.pre > /dev/null This image does not contains a ME/TXE firmware NR = 0) make: *** [src/southbridge/intel/common/firmware/Makefile.inc:55: add_intel_firmware] Error 1 Hence keeping CHECK_ME unset by default. TEST=Succesfully built coreboot for Poppy & booted to OS. Change-Id: Ie6de9fb169ae2225430651fe35109178194f20d3 Signed-off-by: Patrick Georgi Original-Commit-Id: 95d6dd21c95ca1729024b79357b583aebd28f9cc Original-Change-Id: Ib3186498c8da307b686c06c3828e24acbc7f2d17 Original-Signed-off-by: Naresh G Solanki Original-Reviewed-on: https://review.coreboot.org/19257 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Nicola Corna Original-Reviewed-by: Furquan Shaikh Reviewed-on: https://chromium-review.googlesource.com/539212 Commit-Ready: Patrick Georgi Tested-by: Patrick Georgi Reviewed-by: Patrick Georgi --- src/southbridge/intel/common/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index ed7dd29507..9d22b1b04e 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -60,7 +60,7 @@ config ME_BIN_PATH config CHECK_ME bool "Verify the integrity of the supplied ME/TXE firmware" - default y + default n depends on HAVE_ME_BIN && (NORTHBRIDGE_INTEL_NEHALEM || \ NORTHBRIDGE_INTEL_SANDYBRIDGE || \ NORTHBRIDGE_INTEL_IVYBRIDGE || NORTHBRIDGE_INTEL_HASWELL || \