From bd453f2b6f6d3cbd12c779250fc55e776984e1c1 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 5 Mar 2025 15:35:28 +0000 Subject: [PATCH] mb/starlabs/starlite_adl: Add generic Graphics driver config This provides entries in the SSDT for all display devices, which allows the kernel to enumerate them. Change-Id: Ie3fe24be948b256b47eb8d48fd8a84d6daa2702f Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86742 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/starlite_adl/Kconfig | 1 + .../starlite_adl/variants/mk_v/devicetree.cb | 76 +++++++++++++------ 2 files changed, 52 insertions(+), 25 deletions(-) diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 51b762b9e9..6afa6238e7 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -3,6 +3,7 @@ config BOARD_STARLABS_STARLITE_SERIES select BOARD_ROMSIZE_KB_16384 select CRB_TPM select DRIVERS_EFI_VARIABLE_STORE + select DRIVERS_GFX_GENERIC select DRIVERS_I2C_HID select DRIVERS_INTEL_PMC select DRIVERS_OPTION_CFR diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 38fe6d07a4..86324a8385 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -37,7 +37,28 @@ chip soc/intel/alderlake device domain 0 on device ref igpu on - register "gfx" = "GMA_DEFAULT_PANEL(0)" + chip drivers/gfx/generic + register "device_count" = "6" + # [DDIA] eDP + register "device[0].name" = ""LCD0"" + register "device[0].type" = "panel" + # [DDIB] HDMI + register "device[1].name" = ""DD01"" + # [TCP0] Type-C + register "device[2].name" = ""DD02"" + register "device[2].use_pld" = "true" + register "device[2].pld" = "ACPI_PLD_TYPE_C(RIGHT, CENTER, ACPI_PLD_GROUP(0, 0))" + # [TCP1] Type-C + register "device[3].name" = ""DD03"" + register "device[3].use_pld" = "true" + register "device[3].pld" = "ACPI_PLD_TYPE_C(RIGHT, CENTER, ACPI_PLD_GROUP(0, 1))" + # [TCP2] N/A + register "device[4].name" = ""DD04"" + # [TCP3] N/A + register "device[5].name" = ""DD05"" + device generic 0 on end + end + register "ddi_portA_config" = "1" register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, @@ -68,48 +89,53 @@ chip soc/intel/alderlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""Bottom USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(0, 0)" + register "desc" = ""Bottom USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, CENTER, ACPI_PLD_GROUP(0, 0))" + device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""Bottom USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(0, 0)" + register "desc" = ""Bottom USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref usb3_port3 on end end chip drivers/usb/acpi - register "desc" = ""Top USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Top USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, CENTER, ACPI_PLD_GROUP(0, 1))" device ref usb2_port2 on end end chip drivers/usb/acpi - register "desc" = ""Top USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Top USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, CENTER, ACPI_PLD_GROUP(0, 1))" device ref usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""USB 2.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""USB 2.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""USB 2.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 4)" + register "desc" = ""USB 2.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 4)" device ref usb2_port6 on end end chip drivers/usb/acpi - register "desc" = ""CNVi Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - register "is_intel_bluetooth" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_VGPIO_0)" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" - register "group" = "ACPI_PLD_GROUP(0, 5)" + register "desc" = ""CNVi Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_VGPIO_0)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" + register "group" = "ACPI_PLD_GROUP(0, 5)" device ref usb2_port10 on end end end