From bc8876d56da5fb79555f9b660c7557c3e5d1b515 Mon Sep 17 00:00:00 2001 From: Jincheng Li Date: Mon, 23 Jun 2025 11:29:47 +0800 Subject: [PATCH] Revert "soc/intel/xeon_sp/uncore.c: mark TSEG/SMM region as reserved" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 2e495b09d52f83622c83258059de8f5c92b3ef6b. Reason for revert: mmio_tseg is reserved twice in mc_add_dram_resources, where the duplication is introduced by commit 43b0ed708963 ("soc/intel/xeon_sp: Improve final MTRR solution") Change-Id: I0f1bf757d8d1fc449e4efc0ec171c6f982f79e9e Signed-off-by: Jincheng Li Reviewed-on: https://review.coreboot.org/c/coreboot/+/88165 Tested-by: build bot (Jenkins) Reviewed-by: Shuo Liu Reviewed-by: Jérémy Compostella --- src/soc/intel/xeon_sp/uncore.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/soc/intel/xeon_sp/uncore.c b/src/soc/intel/xeon_sp/uncore.c index 85e45db63d..681542e901 100644 --- a/src/soc/intel/xeon_sp/uncore.c +++ b/src/soc/intel/xeon_sp/uncore.c @@ -277,11 +277,6 @@ static void mc_add_dram_resources(struct device *dev, int *res_count) res = ram_from_to(dev, index++, top_of_ram, cbmem_top()); LOG_RESOURCE("cbmem_ram", dev, res); - /* Mark TSEG/SMM region as reserved */ - res = reserved_ram_from_to(dev, index++, mc_values[TSEG_BASE_REG], - mc_values[TSEG_LIMIT_REG] + 1); - LOG_RESOURCE("mmio_tseg", dev, res); - /* Reserve DPR region */ union dpr_register dpr = { .raw = pci_read_config32(dev, VTD_LTDPR) }; if (dpr.size) {