From bbdf2eab6ac83b61012cb732fe5dbe2b13d90357 Mon Sep 17 00:00:00 2001 From: Vince Liu Date: Tue, 21 Oct 2025 15:48:21 +0800 Subject: [PATCH] soc/mediatek: Rename DSI common files for improved readability Rename `common/dsi.c` to `common/dsi_common.c` since this file is used by all SoCs. Rename `common/mtk_dsi_common.c` to `common/dsi_v1.c`, as this file serves as the v1 implementation for all SoCs except mt8173. These changes help clarify file usage and improve code readability. BUG=b:433422905,b:428854543 BRANCH=skywaler TEST=build passed Signed-off-by: Vince Liu Change-Id: Ie711175434febce149a22742d78132842a6ec329 Reviewed-on: https://review.coreboot.org/c/coreboot/+/89655 Reviewed-by: Yu-Ping Wu Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin --- src/soc/mediatek/common/{dsi.c => dsi_common.c} | 0 src/soc/mediatek/common/{mtk_dsi_common.c => dsi_v1.c} | 0 src/soc/mediatek/common/include/soc/dsi_common.h | 2 +- src/soc/mediatek/mt8173/Makefile.mk | 2 +- src/soc/mediatek/mt8183/Makefile.mk | 3 +-- src/soc/mediatek/mt8186/Makefile.mk | 3 +-- src/soc/mediatek/mt8188/Makefile.mk | 3 +-- src/soc/mediatek/mt8192/Makefile.mk | 3 +-- 8 files changed, 6 insertions(+), 10 deletions(-) rename src/soc/mediatek/common/{dsi.c => dsi_common.c} (100%) rename src/soc/mediatek/common/{mtk_dsi_common.c => dsi_v1.c} (100%) diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi_common.c similarity index 100% rename from src/soc/mediatek/common/dsi.c rename to src/soc/mediatek/common/dsi_common.c diff --git a/src/soc/mediatek/common/mtk_dsi_common.c b/src/soc/mediatek/common/dsi_v1.c similarity index 100% rename from src/soc/mediatek/common/mtk_dsi_common.c rename to src/soc/mediatek/common/dsi_v1.c diff --git a/src/soc/mediatek/common/include/soc/dsi_common.h b/src/soc/mediatek/common/include/soc/dsi_common.h index a0acce829b..f5fc70c1c6 100644 --- a/src/soc/mediatek/common/include/soc/dsi_common.h +++ b/src/soc/mediatek/common/include/soc/dsi_common.h @@ -197,7 +197,7 @@ void mtk_dsi_configure_mipi_tx(u32 data_rate, u32 lanes); /* Functions as weak no-ops that can be overridden. */ void mtk_dsi_override_phy_timing(struct mtk_phy_timing *timing); -/* Public API provided in common/dsi.c */ +/* Public API provided in common/dsi_common.c */ int mtk_dsi_bpp_from_format(u32 format); int mtk_dsi_init(u32 mode_flags, u32 format, u32 lanes, const struct edid *edid, const u8 *init_commands); diff --git a/src/soc/mediatek/mt8173/Makefile.mk b/src/soc/mediatek/mt8173/Makefile.mk index 49861a71ac..ef969ab24d 100644 --- a/src/soc/mediatek/mt8173/Makefile.mk +++ b/src/soc/mediatek/mt8173/Makefile.mk @@ -71,7 +71,7 @@ ramstage-y += ../common/rtc.c ../common/rtc_pwrap_ops.c rtc.c ramstage-y += ../common/usb.c usb.c ramstage-y += ../common/ddp.c ddp.c -ramstage-y += ../common/dsi.c dsi.c +ramstage-y += ../common/dsi_common.c dsi.c BL31_MAKEARGS += PLAT=mt8173 diff --git a/src/soc/mediatek/mt8183/Makefile.mk b/src/soc/mediatek/mt8183/Makefile.mk index a4aa9db0ea..70f1b2a664 100644 --- a/src/soc/mediatek/mt8183/Makefile.mk +++ b/src/soc/mediatek/mt8183/Makefile.mk @@ -49,13 +49,12 @@ ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c ramstage-y += emi.c ramstage-y += ../common/auxadc.c ramstage-y += ../common/ddp.c ddp.c -ramstage-y += ../common/dsi.c ../common/mtk_mipi_dphy.c +ramstage-y += ../common/dsi_common.c ../common/dsi_v1.c ../common/mtk_mipi_dphy.c ramstage-y += ../common/gpio_eint_v1.c ../common/gpio.c gpio.c ramstage-y += ../common/i2c.c i2c.c ramstage-y += ../common/mcu.c ramstage-y += ../common/mmu_operations.c mmu_operations.c ramstage-y += ../common/mtcmos.c mtcmos.c -ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmic_wrap.c ramstage-y += ../common/rtc.c ../common/rtc_pwrap_ops.c ../common/rtc_osc_init.c rtc.c ramstage-y += soc.c diff --git a/src/soc/mediatek/mt8186/Makefile.mk b/src/soc/mediatek/mt8186/Makefile.mk index 6625988edd..f066b4bb3a 100644 --- a/src/soc/mediatek/mt8186/Makefile.mk +++ b/src/soc/mediatek/mt8186/Makefile.mk @@ -40,14 +40,13 @@ ramstage-y += ../common/ddp.c ddp.c ramstage-y += ../common/devapc.c devapc.c ramstage-y += ../common/dfd.c ramstage-y += ../common/display.c -ramstage-y += ../common/dsi.c ../common/mtk_mipi_dphy.c +ramstage-y += ../common/dsi_common.c ../common/dsi_v1.c ../common/mtk_mipi_dphy.c ramstage-y += ../common/emi.c ramstage-y += ../common/l2c_ops.c ramstage-y += ../common/mcu.c ramstage-y += ../common/mmu_operations.c ramstage-$(CONFIG_COMMONLIB_STORAGE_MMC) += ../common/msdc.c msdc.c ramstage-y += ../common/mtcmos.c mtcmos.c -ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmic_wrap.c pmic_wrap.c pmif.c mt6366.c ramstage-y += ../common/rtc.c ../common/rtc_pwrap_ops.c ../common/rtc_osc_init.c rtc.c ramstage-y += soc.c diff --git a/src/soc/mediatek/mt8188/Makefile.mk b/src/soc/mediatek/mt8188/Makefile.mk index fa9a8f119a..74ccbbdfac 100644 --- a/src/soc/mediatek/mt8188/Makefile.mk +++ b/src/soc/mediatek/mt8188/Makefile.mk @@ -45,7 +45,7 @@ ramstage-y += ../common/dp/dptx_hal_common.c ../common/dp/dptx_hal_v1.c ramstage-y += ../common/dpm.c ramstage-y += ../common/dpm_v1.c ramstage-$(CONFIG_DPM_FOUR_CHANNEL) += ../common/dpm_4ch.c -ramstage-y += ../common/dsi.c ../common/mtk_mipi_dphy.c +ramstage-y += ../common/dsi_common.c ../common/dsi_v1.c ../common/mtk_mipi_dphy.c ramstage-y += ../common/emi.c ramstage-y += ../common/l2c_ops.c ramstage-y += ../common/mcu.c @@ -54,7 +54,6 @@ ramstage-y += ../common/mmu_operations.c ramstage-$(CONFIG_COMMONLIB_STORAGE_MMC) += ../common/msdc.c msdc.c ramstage-y += ../common/mt6359p.c mt6359p.c ramstage-y += ../common/mtcmos.c mtcmos.c -ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmif.c ../common/pmif_clk.c ../common/pmif_init.c pmif_clk.c ramstage-y += ../common/pmif_spi.c pmif_spi.c ramstage-y += ../common/pmif_spmi.c ../common/pmif_spmi_v1.c pmif_spmi.c diff --git a/src/soc/mediatek/mt8192/Makefile.mk b/src/soc/mediatek/mt8192/Makefile.mk index eaf7bc1856..8bbc8215b9 100644 --- a/src/soc/mediatek/mt8192/Makefile.mk +++ b/src/soc/mediatek/mt8192/Makefile.mk @@ -40,14 +40,13 @@ ramstage-y += devapc.c ramstage-y += ../common/dfd.c ramstage-y += ../common/dpm.c ramstage-y += ../common/dpm_v1.c -ramstage-y += ../common/dsi.c ../common/mtk_mipi_dphy.c +ramstage-y += ../common/dsi_common.c ../common/dsi_v1.c ../common/mtk_mipi_dphy.c ramstage-y += ../common/l2c_ops.c ramstage-y += ../common/mcu.c ramstage-y += ../common/mcupm.c ramstage-y += ../common/mmu_operations.c ramstage-$(CONFIG_COMMONLIB_STORAGE_MMC) += ../common/msdc.c msdc.c ramstage-y += ../common/mtcmos.c mtcmos.c -ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmif.c ../common/pmif_init.c ramstage-y += ../common/rtc.c ../common/rtc_mt6359p.c ramstage-y += soc.c