From ba42b42cda69374654e79af9a3f439818a81d2ed Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 11 Mar 2025 10:18:22 -0500 Subject: [PATCH] soc/intel/skylake: Use common ACPI code for HECI Use the newly-created ACPI device in common/acpi, and adjust the SoC ACPI name for the CSE/HECI device to match. Change-Id: Ie4d9a480152fabb93d784b338c2846feba874f4b Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/86817 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/soc/intel/skylake/acpi/pch.asl | 3 +++ src/soc/intel/skylake/chip.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/soc/intel/skylake/acpi/pch.asl b/src/soc/intel/skylake/acpi/pch.asl index 832663315d..ba9780881c 100644 --- a/src/soc/intel/skylake/acpi/pch.asl +++ b/src/soc/intel/skylake/acpi/pch.asl @@ -43,6 +43,9 @@ /* USB XHCI 0:14.0 */ #include "xhci.asl" +/* CSE/HECI #1 0:16.0 */ +#include + Method (_OSC, 4) { /* Check for proper GUID */ diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c index a6844e068a..d7364fdca2 100644 --- a/src/soc/intel/skylake/chip.c +++ b/src/soc/intel/skylake/chip.c @@ -116,7 +116,7 @@ const char *soc_acpi_name(const struct device *dev) case PCH_DEVFN_I2C1: return "I2C1"; case PCH_DEVFN_I2C2: return "I2C2"; case PCH_DEVFN_I2C3: return "I2C3"; - case PCH_DEVFN_CSE: return "CSE1"; + case PCH_DEVFN_CSE: return "HECI"; case PCH_DEVFN_CSE_2: return "CSE2"; case PCH_DEVFN_CSE_IDER: return "CSED"; case PCH_DEVFN_CSE_KT: return "CSKT";