erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/amd/common/Makefile.mk: Strip quotes from AMDFW_CONFIG_FILE

Browse source 
Strip quotes from CONFIG_AMDFW_CONFIG_FILE, otherwise the IF condition
may not catch the case when CONFIG_AMDFW_CONFIG_FILE is an empty string.

TEST=Omit PSP blobs when building coreboot for Gigabyte MZ33-AR1 by
clearing the AMDFW_CONFIG_FILE path.

Change-Id: I1ecf61844c03c89b3429e23936172f79c8d4b2f4
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90367
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Michał Żygowski 2025-12-04 14:49:52 +01:00 • committed by Felix Held
commit ba0483c94a
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/soc/amd/common/Makefile.mk
View file

@ -11,7 +11,7 @@ ifneq ($(V),)
OPT_DEBUG_AMDFWTOOL = --debug
endif
ifneq ($(CONFIG_AMDFW_CONFIG_FILE), )
ifneq ($(call strip_quotes, $(CONFIG_AMDFW_CONFIG_FILE)),)
FIRMWARE_LOCATION=$(shell grep -e FIRMWARE_LOCATION $(CONFIG_AMDFW_CONFIG_FILE) | awk '{print $$2}')
# Add all the files listed in the config file to the dependency list
@ -77,7 +77,7 @@ amdfwread-range-cmd = $(shell ( \
))
endif # ifeq ($(CONFIG_VBOOT_GSCVD),y)
endif # ifneq ($(CONFIG_AMDFW_CONFIG_FILE), )
endif # ifneq ($(call strip_quotes, $(CONFIG_AMDFW_CONFIG_FILE)),)
MAINBOARD_BLOBS_DIR := $(call strip_quotes, $(CONFIG_APCB_BLOBS_DIR))