erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tree: Use boolean for s3resume

Browse source 
Change-Id: I3e23134f879fcaf817cf62b641e9b59563eb643b
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86331
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Elyes Haouas 2025-02-08 12:19:28 +01:00
commit b87a9795de
67 changed files with 106 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/include/acpi/acpi.h
View file

@ -1975,10 +1975,10 @@ static inline bool acpi_s3_resume_allowed(void)
return CONFIG(HAVE_ACPI_RESUME);
}
static inline int acpi_is_wakeup_s3(void)
static inline bool acpi_is_wakeup_s3(void)
{
if (!acpi_s3_resume_allowed())
return 0;
return false;
if (ENV_ROMSTAGE_OR_BEFORE)
return (acpi_get_sleep_type() == ACPI_S3);

3
src/include/cbmem.h
View file

@ -6,6 +6,7 @@
#include <commonlib/bsd/cbmem_id.h> /* IWYU pragma: export */
#include <stddef.h>
#include <stdint.h>
#include <stdbool.h>
#include <boot/coreboot_tables.h>
#define CBMEM_FSP_HOB_PTR 0x614
@ -86,7 +87,7 @@ u64 cbmem_entry_size(const struct cbmem_entry *entry);
/* Returns 0 if old cbmem was recovered. Recovery is only attempted if
* s3resume is non-zero. */
int cbmem_recovery(int s3resume);
int cbmem_recovery(bool s3resume);
/* Add a cbmem entry of a given size and id. These return NULL on failure. The
* add function performs a find first and do not check against the original
* size. */

5
src/include/romstage_handoff.h
View file

@ -2,10 +2,11 @@
#ifndef ROMSTAGE_HANDOFF_H
#define ROMSTAGE_HANDOFF_H
#include <stdbool.h>
/* Returns 0 if initialized. Else < 0 if handoff structure not added. */
int romstage_handoff_init(int is_s3_resume);
/* Return 1 if resuming or 0 if not. */
int romstage_handoff_is_resume(void);
bool romstage_handoff_is_resume(void);
#endif /* ROMSTAGE_HANDOFF_H */

4
src/include/stage_cache.h
View file

@ -39,10 +39,10 @@ static inline void stage_cache_get_raw(int stage_id, void **base, size_t *size)
#endif
static inline int resume_from_stage_cache(void)
static inline bool resume_from_stage_cache(void)
{
if (CONFIG(NO_STAGE_CACHE))
return 0;
return false;
/* TBD: Replace this with acpi_is_wakeup_s3(). */
return romstage_handoff_is_resume();