From b793209b80565509524e9ff475a950bc2bf90f3d Mon Sep 17 00:00:00 2001 From: Ren Kuo Date: Wed, 11 Dec 2024 12:48:29 +0800 Subject: [PATCH] mb/google/brox/var/jubilant: Disable Tccold Handshake The patch disables Tccold Handshake to prevent possible display flicker issue for jubilant board. Please refer to Intel doc#723158 for more information. BUG=b:383433239 BRANCH=firmware-brox-16080.B TEST=Boot to OS on jubilant, verify the display is without flicker. Change-Id: I4f22067b81fa1b1b9addd7d1f49de59136d221c0 Signed-off-by: Ren Kuo Reviewed-on: https://review.coreboot.org/c/coreboot/+/85555 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/mainboard/google/brox/variants/jubilant/overridetree.cb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb index 4e554ab23a..afcfc7a3ca 100644 --- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb +++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb @@ -21,6 +21,10 @@ end chip soc/intel/alderlake register "platform_pmax" = "208" + # As per Intel Advisory doc#723158, the change is required to prevent possible + # display flickering issue. + register "disable_dynamic_tccold_handshake" = "true" + register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # USB2_C0 register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Disable USB2 Port register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC_SKIP)" # USB2_C2