From b76f2dc35530ecf669094747c3f513673ae54808 Mon Sep 17 00:00:00 2001 From: Zhigang Qin Date: Tue, 8 Apr 2025 18:51:26 +0800 Subject: [PATCH] soc/mediatek/common: Convert mt6359p_read_field() to a general API Make mt6359p_read_field() a general API usable by multiple drivers, instead of a static function limited to the original driver. BUG=b:379008996 BRANCH=none TEST=build pass Signed-off-by: Zhigang Qin Change-Id: I2d9c3de9ad08f918a84fa63c1e9b3af7adc5974a Reviewed-on: https://review.coreboot.org/c/coreboot/+/87336 Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu --- src/soc/mediatek/common/include/soc/mt6359p.h | 1 + src/soc/mediatek/common/mt6359p.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/soc/mediatek/common/include/soc/mt6359p.h b/src/soc/mediatek/common/include/soc/mt6359p.h index fa21eaa06d..b829eb6e83 100644 --- a/src/soc/mediatek/common/include/soc/mt6359p.h +++ b/src/soc/mediatek/common/include/soc/mt6359p.h @@ -88,6 +88,7 @@ void mt6359p_enable_vpa(bool enable); void mt6359p_enable_vsim1(bool enable); void mt6359p_enable_vm18(bool enable); void mt6359p_init_pmif_arb(void); +u32 mt6359p_read_field(u32 reg, u32 mask, u32 shift); void mt6359p_write_field(u32 reg, u32 val, u32 mask, u32 shift); void mt6359p_init_setting(void); void mt6359p_lp_setting(void); diff --git a/src/soc/mediatek/common/mt6359p.c b/src/soc/mediatek/common/mt6359p.c index 530f4d1f87..6b09d57caa 100644 --- a/src/soc/mediatek/common/mt6359p.c +++ b/src/soc/mediatek/common/mt6359p.c @@ -50,7 +50,7 @@ static void mt6359p_write(u32 reg, u32 data) pmif_arb->write(pmif_arb, 0, reg, data); } -static u32 mt6359p_read_field(u32 reg, u32 mask, u32 shift) +u32 mt6359p_read_field(u32 reg, u32 mask, u32 shift) { return pmif_arb->read_field(pmif_arb, 0, reg, mask, shift); }