From b67e001a85a5af83d99705b0a1b8da24482344e5 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sun, 8 Dec 2024 18:21:10 +0530 Subject: [PATCH] soc/intel/pantherlake: Fix UFS ACPI _ADR calculation This patch corrects the calculation of the _ADR value for the Intel UFS controller in the `soc/ufs.h` header file. The previous calculation incorrectly included a hardcoded value (0x0007) in the lower bits of the _ADR. This is not in line with the Panther Lake EDS specification (doc: 815002) BUG=b:382243957 TEST=Able to build and boot google/fatcat. > iasl -d /sys/firmware/acpi/tables/DSDT Device (UFS) { Name (_ADR, 0x00170000) // _ADR: Address Name (_DDN, "UFS Controller") // _DDN: DOS Device Name Name (_DSD, Package (0x02) // _DSD: Device-Specific Data Change-Id: I889403e4d33efb5818fec06d773b5aec0a74d0b3 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/85528 Reviewed-by: Divagar Mohandass Tested-by: build bot (Jenkins) Reviewed-by: Dinesh Gehlot Reviewed-by: Kapil Porwal Reviewed-by: Pranava Y N --- src/soc/intel/pantherlake/include/soc/ufs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/pantherlake/include/soc/ufs.h b/src/soc/intel/pantherlake/include/soc/ufs.h index ffd9b1ff73..e5a87e6732 100644 --- a/src/soc/intel/pantherlake/include/soc/ufs.h +++ b/src/soc/intel/pantherlake/include/soc/ufs.h @@ -11,7 +11,7 @@ #include /* Calculate _ADR for Intel UFS Controller */ -#define UFS_ACPI_DEVICE (PCI_DEV_SLOT_UFS << 16 | 0x0007) +#define UFS_ACPI_DEVICE (PCI_DEV_SLOT_UFS << 16) #define R_SCS_CFG_PCS 0x84 #define R_SCS_CFG_PG_CONFIG 0xA2