mb/starlabs: Use common devtree_update mechanism

Remove the explicit devtree_update() call from mainboard configuration.
The devtree_update hook is provided by src/lib/devtree_update.c and runs
at BS_PRE_DEVICE. Drop the variant declarations from variants.h and add
the devtree_update header in each variant devtree.c so their overrides
are used via the common mechanism.

TEST=build/boot Starlabs Starfighter MTL

Change-Id: Ia7ceaaefe717566c6411f86d81d3a76bdfb2b2ea
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91573
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/mainboard/starlabs/adl/include/variants.h

@@ -13,8 +13,6 @@
 const struct pad_config *variant_gpio_table(size_t *num);
 const struct pad_config *variant_early_gpio_table(size_t *num);
 
-void devtree_update(void);
-
 void starlabs_adl_mainboard_fill_ssdt(const struct device *dev);
 
 #endif /* _BASEBOARD_VARIANTS_H_ */

src/mainboard/starlabs/adl/mainboard.c

@@ -13,8 +13,6 @@ static void starlabs_configure_mainboard(void *unused)
 
 	pads = variant_gpio_table(&num);
 	gpio_configure_pads(pads, num);
-
-	devtree_update();
 }
 
 BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, starlabs_configure_mainboard, NULL);

src/mainboard/starlabs/adl/variants/hz/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/adl/variants/i5/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/adl/variants/y2/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/lite/devtree.c

@@ -3,6 +3,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/lite/include/variants.h

@@ -12,6 +12,4 @@
 const struct pad_config *variant_gpio_table(size_t *num);
 const struct pad_config *variant_early_gpio_table(size_t *num);
 
-void devtree_update(void);
-
 #endif /* _BASEBOARD_VARIANTS_H_ */

src/mainboard/starlabs/starbook/include/variants.h

@@ -12,6 +12,4 @@
 const struct pad_config *variant_gpio_table(size_t *num);
 const struct pad_config *variant_early_gpio_table(size_t *num);
 
-void devtree_update(void);
-
 #endif /* _BASEBOARD_VARIANTS_H_ */

src/mainboard/starlabs/starbook/variants/adl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starbook/variants/adl_n/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starbook/variants/cml/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starbook/variants/kbl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starbook/variants/mtl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starbook/variants/rpl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starbook/variants/tgl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starfighter/include/variants.h

@@ -14,6 +14,4 @@ uint8_t get_memory_config_straps(void);
 const struct pad_config *variant_gpio_table(size_t *num);
 const struct pad_config *variant_early_gpio_table(size_t *num);
 
-void devtree_update(void);
-
 #endif /* _BASEBOARD_VARIANTS_H_ */

src/mainboard/starlabs/starfighter/variants/mtl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>

src/mainboard/starlabs/starfighter/variants/rpl/devtree.c

@@ -4,6 +4,7 @@
 #include <cpu/intel/turbo.h>
 #include <device/device.h>
 #include <device/pci_def.h>
+#include <devtree_update.h>
 #include <option.h>
 #include <static.h>
 #include <types.h>