From afd5e5d4440f9829716b2a07f3a1ecbbf95255c4 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 25 Nov 2025 11:06:06 -0600 Subject: [PATCH] mb/samsung/lumpy: Convert HDA verbs to use AZALIA_PIN_DESC macros Convert raw hexadecimal pin configuration values to use the AZALIA_PIN_DESC macro for improved readability and maintainability. All pin configurations have been verified to generate identical binary output to the original raw verbs: - NID 0x05: Headphone Jack (0x022110f0) - NID 0x06: Internal Speaker (0x901700f0) - NID 0x07: Microphone Jack (0x02a110f0) - NID 0x08: Unused/NC (0x77a70037) - NID 0x09: Unused/NC (0xb7a6003e) - NID 0x0a: SPDIF Out/NC (0x434510f0) No functional changes. Change-Id: Ib2f531575dd0e3cccf41b74e861394f21ce237af Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90215 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/mainboard/samsung/lumpy/hda_verb.c | 85 +++++++++++++++++++++----- 1 file changed, 70 insertions(+), 15 deletions(-) diff --git a/src/mainboard/samsung/lumpy/hda_verb.c b/src/mainboard/samsung/lumpy/hda_verb.c index b3350a1300..8c538d6853 100644 --- a/src/mainboard/samsung/lumpy/hda_verb.c +++ b/src/mainboard/samsung/lumpy/hda_verb.c @@ -11,30 +11,85 @@ const u32 cim_verb_data[] = { /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x152D0924 */ AZALIA_SUBVENDOR(0, 0x152D0924), + /* Padding - Power up sequence */ + 0x00170500, + 0x00170500, + 0x00170500, 0x00170500, - 0x00170500, /* Padding */ - 0x00170500, /* Padding */ - 0x00170500, /* Padding */ /* Pin Widget Verb Table */ - /* Pin Complex (NID 0x05) */ - AZALIA_PIN_CFG(0, 0x05, 0x022110f0), + /* Pin Complex (NID 0x05) - Headphone Jack */ + AZALIA_PIN_CFG(0, 0x05, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT, + AZALIA_HP_OUT, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 15, + 0 + )), - /* Pin Complex (NID 0x06) */ - AZALIA_PIN_CFG(0, 0x06, 0x901700f0), + /* Pin Complex (NID 0x06) - Internal Speaker */ + AZALIA_PIN_CFG(0, 0x06, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_INTERNAL, + AZALIA_SPEAKER, + AZALIA_OTHER_ANALOG, + AZALIA_COLOR_UNKNOWN, + AZALIA_JACK_PRESENCE_DETECT, + 15, + 0 + )), - /* Pin Complex (NID 0x07) */ - AZALIA_PIN_CFG(0, 0x07, 0x02a110f0), + /* Pin Complex (NID 0x07) - Microphone Jack */ + AZALIA_PIN_CFG(0, 0x07, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT, + AZALIA_MIC_IN, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 15, + 0 + )), - /* Pin Complex (NID 0x08) */ - AZALIA_PIN_CFG(0, 0x08, 0x77a70037), + /* Pin Complex (NID 0x08) - Unused (NC) */ + AZALIA_PIN_CFG(0, 0x08, AZALIA_PIN_DESC( + AZALIA_NC, + AZALIA_MOBILE_LID_INSIDE, + AZALIA_MIC_IN, + AZALIA_OTHER_ANALOG, + AZALIA_COLOR_UNKNOWN, + AZALIA_JACK_PRESENCE_DETECT, + 3, + 7 + )), - /* Pin Complex (NID 0x09) */ - AZALIA_PIN_CFG(0, 0x09, 0xb7a6003e), + /* Pin Complex (NID 0x09) - Internal Digital Mic */ + AZALIA_PIN_CFG(0, 0x09, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_MOBILE_LID_INSIDE, + AZALIA_MIC_IN, + AZALIA_OTHER_DIGITAL, + AZALIA_COLOR_UNKNOWN, + AZALIA_JACK_PRESENCE_DETECT, + 3, + 14 + )), - /* Pin Complex (NID 0x0a) */ - AZALIA_PIN_CFG(0, 0x0a, 0x434510f0), + /* Pin Complex (NID 0x0a) - SPDIF Out (NC) */ + AZALIA_PIN_CFG(0, 0x0a, AZALIA_PIN_DESC( + AZALIA_NC, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_LEFT, + AZALIA_SPDIF_OUT, + AZALIA_OPTICAL, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 15, + 0 + )), }; const u32 pc_beep_verbs[] = {