From afc49fa01317190c0ffe480967ee89243d419777 Mon Sep 17 00:00:00 2001 From: Jincheng Li Date: Wed, 11 Sep 2024 13:15:01 +0800 Subject: [PATCH] soc/intel/xeon_sp: Remove lpc_lockdown_config If CHIPSET_LOCKDOWN_COREBOOT is selected, lpc_lockdown_config() will be executed in common pch/lockdown firstly. Remove xeon_sp layer lpc_lockdown_config() to avoid duplication. The duplicated part are in src/soc/intel/common/pch/lockdown/lockdown.c: static void platform_lockdown_config(void *unused) { int chipset_lockdown; chipset_lockdown = get_lockdown_config(); /* SPI lock down configuration */ fast_spi_lockdown_cfg(chipset_lockdown); /* LPC/eSPI lock down configuration */ lpc_lockdown_config(chipset_lockdown); ... } Change-Id: Ibec389a6d55c7885def6896a0ea435514b75a323 Signed-off-by: Jincheng Li Reviewed-on: https://review.coreboot.org/c/coreboot/+/85286 Reviewed-by: Shuo Liu Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph --- src/soc/intel/xeon_sp/lockdown.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/soc/intel/xeon_sp/lockdown.c b/src/soc/intel/xeon_sp/lockdown.c index a3d17b46c3..f638c2b9d1 100644 --- a/src/soc/intel/xeon_sp/lockdown.c +++ b/src/soc/intel/xeon_sp/lockdown.c @@ -6,25 +6,11 @@ #include #include -static void lpc_lockdown_config(void) -{ - /* Set BIOS Interface Lock, BIOS Lock */ - lpc_set_bios_interface_lock_down(); - - /* Only allow writes in SMM */ - if (CONFIG(BOOTMEDIA_SMM_BWP)) { - lpc_set_eiss(); - lpc_enable_wp(); - } - lpc_set_lock_enable(); -} - void soc_lockdown_config(int chipset_lockdown) { if (chipset_lockdown == CHIPSET_LOCKDOWN_FSP) return; - lpc_lockdown_config(); pmc_lockdown_config(); sata_lockdown_config(chipset_lockdown); spi_lockdown_config(chipset_lockdown);