From af8b15ae0489d390170ddbb585f049cccc0cb1d9 Mon Sep 17 00:00:00 2001 From: Yu-Ping Wu Date: Thu, 9 Oct 2025 07:31:12 +0000 Subject: [PATCH] Revert "libpayload: Define UCHAR_MAX/CHAR_MIN/CHAR_MAX" This reverts commit 4f13f72dbc40 ("libpayload: Define UCHAR_MAX/CHAR_MIN/CHAR_MAX"). Reason for revert: char can be either signed or unsigned. If it's unsigned, then CHAR_MIN would be incorrectly defined as 128. Change-Id: Id49ddfff2d91029dc191b8b64e8e3f325ad0a462 Signed-off-by: Yu-Ping Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/89469 Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) --- payloads/libpayload/include/limits.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/payloads/libpayload/include/limits.h b/payloads/libpayload/include/limits.h index c712b60bfd..53adfcb98c 100644 --- a/payloads/libpayload/include/limits.h +++ b/payloads/libpayload/include/limits.h @@ -41,10 +41,6 @@ #define CHAR_BIT 8 -#define UCHAR_MAX ((unsigned char)~0U) -#define CHAR_MIN ((char)(UCHAR_MAX & ~(UCHAR_MAX >> 1))) -#define CHAR_MAX ((char)(UCHAR_MAX >> 1)) - #define USHRT_MAX ((unsigned short int)~0U) #define SHRT_MIN ((short int)(USHRT_MAX & ~(USHRT_MAX >> 1))) #define SHRT_MAX ((short int)(USHRT_MAX >> 1))