erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

region: Introduce region_create() functions

Browse source 
We introduce two new functions to create region objects. They allow us
to check for integer overflows (region_create_untrusted()) or assert
their absence (region_create()).

This fixes potential overflows in region_overlap() checks in SMI
handlers, where we would wrongfully report MMIO as *not* overlapping
SMRAM.

Also, two cases of strtol() in parse_region() (cbfstool),  where the
results were implicitly converted to `size_t`, are replaced with the
unsigned strtoul().

FIT payload support is left out, as it doesn't use the region API
(only the struct).

Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b
Ticket: https://ticket.coreboot.org/issues/522
Found-by: Vadim Zaliva <lord@digamma.ai>
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79905
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Nico Huber 2024-01-11 18:59:24 +01:00 • committed by Felix Held
commit af0d4bce65
12 changed files with 95 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/soc/qualcomm/common/qclib.c
View file

@ -101,9 +101,8 @@ static void write_ddr_information(struct qclib_cb_if_table_entry *te)
uint64_t ddr_size;
/* Save DDR info in SRAM region to share with ramstage */
ddr_region->offset = te->blob_address;
ddr_size = te->size;
ddr_region->size = ddr_size * MiB;
*ddr_region = region_create(te->blob_address, ddr_size * MiB);
/* Use DDR info to configure MMU */
qc_mmu_dram_config_post_dram_init(