region: Introduce region_create() functions
We introduce two new functions to create region objects. They allow us to check for integer overflows (region_create_untrusted()) or assert their absence (region_create()). This fixes potential overflows in region_overlap() checks in SMI handlers, where we would wrongfully report MMIO as *not* overlapping SMRAM. Also, two cases of strtol() in parse_region() (cbfstool), where the results were implicitly converted to `size_t`, are replaced with the unsigned strtoul(). FIT payload support is left out, as it doesn't use the region API (only the struct). Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b Ticket: https://ticket.coreboot.org/issues/522 Found-by: Vadim Zaliva <lord@digamma.ai> Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79905 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
parent
0e9830884c
commit
af0d4bce65
12 changed files with 95 additions and 75 deletions
|
|
@ -142,7 +142,10 @@ bool smm_region_overlaps_handler(const struct region *r);
|
|||
/* Returns true if the memory pointed to overlaps with SMM reserved memory. */
|
||||
static inline bool smm_points_to_smram(const void *ptr, const size_t len)
|
||||
{
|
||||
const struct region r = {(uintptr_t)ptr, len};
|
||||
struct region r;
|
||||
|
||||
if (region_create_untrusted(&r, (uintptr_t)ptr, len) != CB_SUCCESS)
|
||||
return true; /* Play it safe and pretend it overlaps if we can't tell. */
|
||||
|
||||
return smm_region_overlaps_handler(&r);
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue