erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

src/security: Use "if (!ptr)" in preference to "if (ptr == NULL)"

Browse source 
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: I3def65c016015d8213824e6b8561d8a67b6d5cf0
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67579
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
This commit is contained in:
Elyes Haouas 2022-09-13 09:56:22 +02:00 • committed by Felix Held
commit aebccac7e1
6 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/security/vboot/common.c
View file

@ -17,10 +17,10 @@ static void *vboot_get_workbuf(void)
if (cbmem_possibly_online())
wb = cbmem_find(CBMEM_ID_VBOOT_WORKBUF);
if (wb == NULL && !CONFIG(VBOOT_STARTS_IN_ROMSTAGE) && preram_symbols_available())
if (!wb && !CONFIG(VBOOT_STARTS_IN_ROMSTAGE) && preram_symbols_available())
wb = _vboot2_work;
assert(wb != NULL);
assert(wb);
return wb;
}
@ -72,7 +72,7 @@ static void vboot_setup_cbmem(int unused)
vb2_error_t rv;
const size_t cbmem_size = VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE;
void *wb_cbmem = cbmem_add(CBMEM_ID_VBOOT_WORKBUF, cbmem_size);
assert(wb_cbmem != NULL);
assert(wb_cbmem);
/*
* On platforms where VBOOT_STARTS_BEFORE_BOOTBLOCK, the verification
* occurs before the main processor starts running. The vboot data-

2
src/security/vboot/ec_sync.c
View file

@ -383,7 +383,7 @@ static vb2_error_t ec_get_expected_hash(enum vb2_firmware_selection select,
/* vboot has no API to return this memory, so must permanently leak a mapping here. */
const uint8_t *file = cbfs_map(filename, &size);
if (file == NULL)
if (!file)
return VB2_ERROR_UNKNOWN;
*hash = file;