erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/pantherlake: Refactor FSP-M params for debug message control

Browse source 
The fsp_params.c file is refactored to move the debug message
control logic to a separate function, fsp_control_log_level().
This function takes an FSPM_UPD pointer and a boolean value
indicating whether debug messages should be enabled or disabled.

The fill_fsp_event_handler() function is updated to call
fsp_control_log_level() with the appropriate boolean value based on
the CONFIG(CONSOLE_SERIAL) and CONFIG(FSP_ENABLE_SERIAL_DEBUG)
Kconfig options.

BUG=b:227151510
TEST=Able to build and boot google/fatcat.

Change-Id: Ie2916ce82133058464d20eed327de7c7288e78a4
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85827
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2025-01-02 14:37:18 +05:30
commit add685507b
1 changed files with 25 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/soc/intel/pantherlake/romstage/fsp_params.c
View file

@ -296,35 +296,44 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg,
fill_fspm_params[i](m_cfg, config);
}
static void fill_fsp_event_handler(FSPM_ARCH2_UPD *arch_upd, FSP_M_CONFIG *m_cfg)
static void fsp_control_log_level(FSPM_UPD *mupd, bool is_enabled)
{
if (!CONFIG(FSP_USES_CB_DEBUG_EVENT_HANDLER))
return;
FSP_M_CONFIG *m_cfg = &mupd->FspmConfig;
FSPM_ARCHx_UPD *arch_upd = &mupd->FspmArchUpd;
if (!CONFIG(CONSOLE_SERIAL) || !CONFIG(FSP_ENABLE_SERIAL_DEBUG)) {
if (is_enabled) {
enum fsp_log_level log_level = fsp_map_console_log_level();
arch_upd->FspEventHandler = (uintptr_t)((FSP_EVENT_HANDLER *)fsp_debug_event_handler);
/* Set Serial debug message level */
m_cfg->PcdSerialDebugLevel = log_level;
/* Set MRC debug level */
m_cfg->SerialDebugMrcLevel = log_level;
} else {
/* Disable Serial debug message */
m_cfg->PcdSerialDebugLevel = 0;
/* Disable MRC debug message */
m_cfg->SerialDebugMrcLevel = 0;
return;
}
}
enum fsp_log_level log_level = fsp_map_console_log_level();
arch_upd->FspEventHandler = (uintptr_t)((FSP_EVENT_HANDLER *)fsp_debug_event_handler);
/* Set Serial debug message level */
m_cfg->PcdSerialDebugLevel = log_level;
/* Set MRC debug level */
m_cfg->SerialDebugMrcLevel = log_level;
static void fill_fsp_event_handler(FSPM_UPD *mupd)
{
bool fsp_debug_enable = false;
if (CONFIG(CONSOLE_SERIAL) && CONFIG(FSP_ENABLE_SERIAL_DEBUG))
fsp_debug_enable = true;
fsp_control_log_level(mupd, fsp_debug_enable);
}
void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)
{
const struct soc_intel_pantherlake_config *config = config_of_soc();
FSP_M_CONFIG *m_cfg = &mupd->FspmConfig;
FSPM_ARCH2_UPD *arch_upd = &mupd->FspmArchUpd;
fill_fsp_event_handler(arch_upd, m_cfg);
soc_memory_init_params(m_cfg, config);
if (CONFIG(FSP_USES_CB_DEBUG_EVENT_HANDLER))
fill_fsp_event_handler(mupd);
soc_memory_init_params(&mupd->FspmConfig, config);
mainboard_memory_init_params(mupd);
}