From ac8765c88a37bc94fcc96dc2bd77eb8e60e735a1 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 2 Oct 2025 14:50:12 +0100 Subject: [PATCH] mb/starlabs/*: Correct USB Type-C Port Configuration The macro USB2_PORTS_MID vs USB2_PORTS_TYPE_C essentially enables or disables the PortResetMessage. This is only relevant to TCSS ports. Correct the macros accordingly. Change-Id: I18a078c7f6fb937293e6159f05587b7e1f881512 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/89513 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb | 2 +- src/mainboard/starlabs/starbook/variants/cml/devicetree.cb | 2 +- src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb | 2 +- src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb | 2 +- src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb index a85936813c..6cb92be551 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb @@ -39,7 +39,7 @@ chip soc/intel/alderlake device ref gna on end device ref xhci on # Front USB 3.0 Type-C - register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC_SKIP)" # Back Top USB 3.0 Type-A diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 900c504e3d..c9595dc6fd 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -53,7 +53,7 @@ chip soc/intel/cannonlake end device ref xhci on # Motherboard USB 3.0 Type-C - register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" + register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 Type-A diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 213cf56960..f2e9376bd0 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -49,7 +49,7 @@ chip soc/intel/skylake end device ref south_xhci on # Motherboard USB Type C - register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" + register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 1862070935..e838c79256 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -106,7 +106,7 @@ chip soc/intel/alderlake device ref gna on end device ref xhci on # Motherboard USB TBT Type-C - register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 Type-A diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index c82bc9aaf0..c911b05a4b 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -121,11 +121,11 @@ chip soc/intel/alderlake device ref gna on end device ref xhci on # Motherboard USB TBT Type-C #0 - register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC_SKIP)" # Motherboard USB TBT Type-C #1 - register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC_SKIP)" register "tcss_ports[1]" = "TCSS_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 Type-A