erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/amd/stoneyridge: Fix _INI method in SSDT for HDA

Browse source 
CB:40785 ("soc/amd/hda: Move HDA PCI device from DSDT to SSDT") moved
the HDA device in ACPI from DSDT to SSDT. During this, _INI method
generated in SSDT incorrectly inverted the values for NSEN, NSDO and
NSDI. This change fixes the mistake so that the _INI in SSDT matches
the original _INI in DSDT for HDA device.

Change-Id: I294b561a479b77ab8afb5f3e0de367ad24f3a764
Reported-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50927
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Furquan Shaikh 2021-02-19 10:23:17 -08:00 • committed by Kyösti Mälkki
commit ac204ba6b5
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/soc/amd/stoneyridge/northbridge.c
View file

@ -530,9 +530,9 @@ void hda_soc_ssdt_quirks(const struct device *dev)
acpigen_write_if_lequal_namestr_int("OSVR", 0x03);
acpigen_write_store_op_to_namestr(ONE_OP, "NSEN");
acpigen_write_store_op_to_namestr(ZERO_OP, "NSDO");
acpigen_write_store_op_to_namestr(ZERO_OP, "NSDI");
acpigen_write_store_op_to_namestr(ZERO_OP, "NSEN");
acpigen_write_store_op_to_namestr(ONE_OP, "NSDO");
acpigen_write_store_op_to_namestr(ONE_OP, "NSDI");
acpigen_pop_len(); /* If */