From a9997f2d7f05adcb157f85d140de723a5254d8ff Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sun, 27 Jul 2025 18:18:14 +0530 Subject: [PATCH] soc/intel/cmn/block: Request bus master in final op for DSP and HDA This commit assigns pci_dev_request_bus_master to the .final operation for both the DSP and HDA device operations to ensure that the bus master is enabled. This change ensures correct PCI configuration for DSP and HDA devices, preventing potential issues with direct memory access operations. BUG=b:427091370 TEST=Able to build and boot google/fatcat. w/o this patch ``` firmware-shell: pcir.b 0 0x1f 3 0x4 0x02 ``` w/ this patch: ``` firmware-shell: pcir.b 0 0x1f 3 0x4 0x06 ``` Change-Id: Id2480dba08ea8ee7a9219327b8a31f8f9f65410c Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/88575 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/soc/intel/common/block/dsp/dsp.c | 1 + src/soc/intel/common/block/hda/hda.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/soc/intel/common/block/dsp/dsp.c b/src/soc/intel/common/block/dsp/dsp.c index af43a99e77..9155a2a7b7 100644 --- a/src/soc/intel/common/block/dsp/dsp.c +++ b/src/soc/intel/common/block/dsp/dsp.c @@ -10,6 +10,7 @@ static struct device_operations dsp_dev_ops = { .enable_resources = pci_dev_enable_resources, .ops_pci = &pci_dev_ops_pci, .scan_bus = scan_static_bus, + .final = pci_dev_request_bus_master, }; static const unsigned short pci_device_ids[] = { diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index 37dc9ea91b..f5e22bc6d9 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -24,6 +24,7 @@ struct device_operations hda_ops = { .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = hda_init, + .final = pci_dev_request_bus_master, .ops_pci = &pci_dev_ops_pci, .scan_bus = scan_static_bus };