erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/tigerlake/acpi: Fix scope of IOM ACPI device

Browse source 
Since the IOM region is outside of the PCH MMIO address space, Windows
will report a device error for the IOM since the ACPI scope
is under PCI0, but the assigned resource range is not inside an
address range for any of PCI0's resources.

Correct this by setting the scope of the IOM device to just _SB.

TEST=build/boot Win11 on google/drobit, verify USB-C ports functional
and coolstar's IOM/TCSS drivers loaded without error.

Change-Id: Ia089e723ccac5508cfaffc0204815b80bb209dd0
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86819
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2025-03-11 10:52:13 -05:00
commit a98514188b
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/soc/intel/tigerlake/acpi/tcss.asl
View file

@ -321,7 +321,7 @@ Scope (_GPE)
}
}
Scope (\_SB.PCI0)
Scope (\_SB)
{
Device (IOM)
{
@ -334,7 +334,10 @@ Scope (\_SB.PCI0)
/* ACPI_STATUS_DEVICE_HIDDEN_ON */
Name (_STA, 0xB)
}
}
Scope (\_SB.PCI0)
{
/*
* Operation region defined to access the TCSS_DEVEN. Get the MCHBAR in offset
* 0x48 in B0:D0:F0. TCSS device enable base address is in offset 0x7090 of MCHBAR.