From a8e1113e3b6d8e92df05227974997d8f177479d2 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sun, 20 Apr 2025 14:11:58 -0600 Subject: [PATCH] util/abuild: Check functions directly instead of with $? Change-Id: I5d28e8f9533602a2ffbacd858c7380af08b56788 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/c/coreboot/+/87376 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- util/abuild/abuild | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index e2ce6dcd46..ad708d7b4b 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -535,24 +535,21 @@ build_config() fi if [[ "${clang}" = true ]]; then - check_config "${build_dir}" "clang" "CONFIG_COMPILER_LLVM_CLANG=y" - if [[ $? -ne 0 ]]; then + if ! check_config "${build_dir}" "clang" "CONFIG_COMPILER_LLVM_CLANG=y"; then printf "%s doesn't support clang, skipping.\n" "${MAINBOARD}" return fi fi if [[ -n "${skipconfig_set}" ]]; then - check_config "${build_dir}" "config value" "CONFIG_${skipconfig_set}=y" negate - if [[ $? -ne 0 ]]; then + if ! check_config "${build_dir}" "config value" "CONFIG_${skipconfig_set}=y" negate; then printf "%s has %s set. Skipping at user's request.\n" "${MAINBOARD}" "${skipconfig_set}" return fi fi if [[ -n "${skipconfig_unset}" ]]; then - check_config "${build_dir}" "config value" "CONFIG_${skipconfig_unset}=y" - if [[ $? -ne 0 ]]; then + if ! check_config "${build_dir}" "config value" "CONFIG_${skipconfig_unset}=y"; then printf "%s does not have %s set. Skipping at user's request.\n" "${MAINBOARD}" "${skipconfig_unset}" return fi