From a857c8112254954c2e03f67d2fc0235f7eccb1b8 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Sat, 14 Dec 2024 10:28:48 +0100 Subject: [PATCH] arch/x86: Disable DEBUG_STACK_OVERFLOW_BREAKPOINTS_IN_ALL_STAGES Disable the debug code as there were unexplainable stack corruptions detected on some platforms. No problems were observed on: - QEMU - Xeon-SP Change-Id: I1f1b9f01af7fbb0c19becf6ea53d436898584c5e Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/85594 Reviewed-by: Angel Pons Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/arch/x86/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 20774055f3..7ef1a6d5c4 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -377,8 +377,11 @@ config DEBUG_STACK_OVERFLOW_BREAKPOINTS config DEBUG_STACK_OVERFLOW_BREAKPOINTS_IN_ALL_STAGES bool - default y + default n depends on DEBUG_STACK_OVERFLOW_BREAKPOINTS && DEBUG_HW_BREAKPOINTS_IN_ALL_STAGES + help + Disabled as false-positive stack corruptions where observed on some platforms. + TODO: Investigate those reported errors before defaulting to yes. # Some EC need an "EC firmware pointer" (a data structure hinting the address # of its firmware blobs) being put at a fixed position. Its space