From a81e09612b2135c8874137af176ccc8443e8a9d3 Mon Sep 17 00:00:00 2001 From: Yidi Lin Date: Tue, 14 Jan 2025 18:58:55 +0800 Subject: [PATCH] soc/mediatek/mt8196: Initialize PMIF for SD Card mt6373_init_pmif_arb() needs to be initialized for SD card to control the regulator. TEST=emrege-rauru coreboot TEST=The assertion is gone on Rauru during normal boot. Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Signed-off-by: Yidi Lin Reviewed-on: https://review.coreboot.org/c/coreboot/+/85969 Reviewed-by: Yu-Ping Wu Tested-by: build bot (Jenkins) --- src/soc/mediatek/mt8196/msdc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/soc/mediatek/mt8196/msdc.c b/src/soc/mediatek/mt8196/msdc.c index f7873741b0..c24bc42502 100644 --- a/src/soc/mediatek/mt8196/msdc.c +++ b/src/soc/mediatek/mt8196/msdc.c @@ -7,6 +7,7 @@ #include #include +#include #include static const struct pad_func sdcard_pins[] = { @@ -29,6 +30,7 @@ void mtk_msdc_configure_sdcard(void) } /* enable SD card power */ + mt6373_init_pmif_arb(); mainboard_enable_regulator(MTK_REGULATOR_VMCH, true); mainboard_enable_regulator(MTK_REGULATOR_VMC, true); mainboard_set_regulator_voltage(MTK_REGULATOR_VMCH, 3000000);