erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: util/romcc: avoid dereferencing NULL pointer

Browse source 
argv is only filled for macro->argc > 0.

BUG=None
BRANCH=None
TEST=None

Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1287089
Reviewed-on: https://review.coreboot.org/18016
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>

Change-Id: I5ff21098384afc823efa14be3d5565507fb2b3b2
Reviewed-on: https://chromium-review.googlesource.com/425285
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Patrick Georgi 2017-01-02 19:15:44 +01:00 • committed by chrome-bot
commit a722342286
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
util/romcc/romcc.c
View file

@ -4580,6 +4580,9 @@ static void expand_macro(struct compile_state *state,
flen = fmacro.pos - fstart;
switch(tk->tok) {
case TOK_IDENT:
if (macro->argc < 0) {
break;
}
for(i = 0; i < macro->argc; i++) {
if (argv[i].ident == tk->ident) {
break;