From a6842184abfdfdf10d2b38223bb03ff09102b021 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 21 Jul 2025 14:35:14 +0000 Subject: [PATCH] mb/google/fatcat/var/kinmen: Use ACPI for touchscreen power sequencing This commit removes redundant touchscreen GPIO configurations from romstage_gpio_table. These GPIOs are no longer required to be explicitly set for the touchscreen while using ACPI for touchscreen power sequencing. When the generic.use_gpio_for_status flag is enabled, the touchscreen driver's power resource method will perform a probe to determine the device's operational status. This probe specifically verifies two critical conditions: - The Enable GPIO pin is enabled (HIGH). - The Reset GPIO pin is not in reset (LOW). If both of these conditions are met, the touchscreen is considered ready and functional. Conversely, if either of these conditions is not met, the _ON method within the power resource will be invoked. The _ON method is then responsible for executing the full touchscreen initialization sequence to bring the device into an operational state. BUG=b:430444353 TEST=Able to build and boot google/kinmen. Verified touchscreen is working as expected with this patch. Change-Id: I0bb2e1ddd4168ef1831b30817dbb3bc3f6e6a5d2 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/88518 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/fatcat/variants/kinmen/gpio.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/kinmen/gpio.c b/src/mainboard/google/fatcat/variants/kinmen/gpio.c index ae339809e8..9a28421783 100644 --- a/src/mainboard/google/fatcat/variants/kinmen/gpio.c +++ b/src/mainboard/google/fatcat/variants/kinmen/gpio.c @@ -424,10 +424,6 @@ static const struct pad_config romstage_gpio_table[] = { PAD_CFG_GPO(GPP_E19, 0, DEEP), /* GPP_C15: FPS_RST_N */ PAD_CFG_GPO(GPP_C15, 0, DEEP), - /* GPP_F08: EN_TCHSCR_PWR */ - PAD_CFG_GPO(GPP_F08, 1, DEEP), - /* GPP_F16: TCHSCR_RST_L */ - PAD_CFG_GPO(GPP_F16, 0, DEEP), }; const struct pad_config *variant_gpio_table(size_t *num)