From a348ef46dbccb1cdbdc678643b627f30ce8b992b Mon Sep 17 00:00:00 2001 From: Luca Lai Date: Fri, 5 Sep 2025 22:37:45 +0800 Subject: [PATCH] mb/google/trulo/var/pujjolo: Change setting for lite ISH fw Use fw config bit 29 to identify different ish files in pujjolo when ISH_PRESENT and pujjoquince when ISH_ABSENT. ISH_PRESENT : pujjolo_ish.bin ISH_ABSENT : lite_ish.bin BUG=b:437881361 TEST=Build and boot to OS, check pujjolo and pujjoquince load corresponding ish file using command ectool --name=cros_ish version and test warmboot/coldboot/suspend pass. Change-Id: I61b90881abcad368dd668f2631f061b0ea00b57f Signed-off-by: Luca Lai Reviewed-on: https://review.coreboot.org/c/coreboot/+/89074 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- .../google/brya/variants/pujjolo/overridetree.cb | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb index 3b8bd5f0ce..b897edbd5d 100644 --- a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb @@ -518,10 +518,17 @@ chip soc/intel/alderlake chip drivers/intel/ish register "add_acpi_dma_property" = "true" register "firmware_name" = ""pujjolo_ish.bin"" - device generic 0 on + device generic 1 on probe ISH ISH_PRESENT end end + chip drivers/intel/ish + register "add_acpi_dma_property" = "true" + register "firmware_name" = ""lite_ish.bin"" + device generic 0 on + probe ISH ISH_ABSENT + end + end end device ref ufs on end device ref igpu on