From a2ea41c6fc93cbf95f9379dea819e406df435e15 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Thu, 13 Apr 2017 10:26:03 -0700 Subject: [PATCH] UPSTREAM: mainboard/google/poppy: Enable deep S3 in DC mode Enable lower power state when running on battery. Deep S3 is not enabled when in AC mode to support standard "docked" config. BUG=b:36087058,b:36723679 TEST=Verified following behavior with USB mouse: 1. If AC is connected when entering S3, USB mouse is able to wake up. 2. If AC is not connected when entering S3, USB mouse does not wake up. 3. If AC is connected when entering S3 and removed after entering S3, USB mouse does not wake up. 4. If AC is not connected when entering S3 and attached after entering S3, USB mouse does not wake up. Change-Id: Ie0d0063c572d7b516bb556d6ef38a10eebd02bd5 Signed-off-by: Patrick Georgi Original-Commit-Id: 55d9c0bd8d5b5d079d98619ee8e1e609a465f5c1 Original-Change-Id: I141a8d4779de004e27fcd9357cef787a38a27b24 Original-Signed-off-by: Furquan Shaikh Original-Reviewed-on: https://review.coreboot.org/19276 Original-Reviewed-by: Paul Menzel Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/481281 --- src/mainboard/google/poppy/devicetree.cb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/poppy/devicetree.cb b/src/mainboard/google/poppy/devicetree.cb index ed25136ba3..c714d0b75a 100644 --- a/src/mainboard/google/poppy/devicetree.cb +++ b/src/mainboard/google/poppy/devicetree.cb @@ -2,7 +2,7 @@ chip soc/intel/skylake # Deep Sx states register "deep_s3_enable_ac" = "0" - register "deep_s3_enable_dc" = "0" + register "deep_s3_enable_dc" = "1" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN"