erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/fatcat: Enable HAVE_SLP_S0_GATE for felino and francka

Browse source 
The fatcat variant now handles SLP_S0 pin functionality natively,
removing the need for HAVE_SLP_S0_GATE. However, other variants like
felino and francka boards still rely on this Kconfig option for proper
sleep state gating. This commit re-enables it for these specific boards.

TEST=Able to build and boot google/fatcat.

Change-Id: Ib7e683c3fee575245e8796638260f1fd8e6e5c34
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86983
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Ian Feng <ian_feng@compal.corp-partner.google.com>
Reviewed-by: Dinesh Gehlot <digehlot@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2025-03-24 18:09:16 +05:30
commit 9f39d6ec5e
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/mainboard/google/fatcat/Kconfig
View file

@ -47,7 +47,6 @@ config BOARD_GOOGLE_BASEBOARD_FATCAT
select DRIVERS_INTEL_ISH
select DRIVER_INTEL_ISH_HAS_MAIN_FW
select DRIVERS_INTEL_USB4_RETIMER
select HAVE_SLP_S0_GATE
select MAINBOARD_HAS_CHROMEOS
select MEMORY_SOLDERDOWN
select SOC_INTEL_COMMON_BLOCK_HDA_VERB
@ -80,10 +79,12 @@ config BOARD_GOOGLE_FATCATITE
config BOARD_GOOGLE_FELINO
select BOARD_GOOGLE_BASEBOARD_FATCAT
select HAVE_SLP_S0_GATE
select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD
config BOARD_GOOGLE_FRANCKA
select BOARD_GOOGLE_BASEBOARD_FATCAT
select HAVE_SLP_S0_GATE
if BOARD_GOOGLE_FATCAT_COMMON