From 9f0f373ff90de012a272432ccfcd46c3272be35e Mon Sep 17 00:00:00 2001 From: Anand Vaikar Date: Thu, 16 Oct 2025 16:21:52 +0530 Subject: [PATCH] mainboard/amd/crater: Select the option to keep the AMD ACP active in S3 Issue=ACP is not active in S3 state and audio playback doesnt work Fix=Introduce a config option to control this setting. TEST=Tested this in ACPI S3 state,by connecting an external CODEC and transmitting a known pattern to the ACP via the I2S TDM controller RX lines and ensuring that the sound is output to the speaker connected to the CODEC via the TDM TX line. Change-Id: Ifbd3e72a4d018e4a14d9459dd3a6804dd27050e4 Signed-off-by: Anand Vaikar Reviewed-on: https://review.coreboot.org/c/coreboot/+/89610 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/amd/crater/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/amd/crater/Kconfig b/src/mainboard/amd/crater/Kconfig index 136d1b834c..3312988926 100644 --- a/src/mainboard/amd/crater/Kconfig +++ b/src/mainboard/amd/crater/Kconfig @@ -18,6 +18,7 @@ config BOARD_AMD_CRATER_COMMON select SPI_FLASH_EXIT_4_BYTE_ADDR_MODE select SOC_AMD_COMMON_BLOCK_PSP_RPMC select SOC_AMD_COMMON_BLOCK_PSP_SMI + select KEEP_ACP_RUNNING_IN_S3 config BOARD_AMD_CRATER_RENOIR select BOARD_AMD_CRATER_COMMON