erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/*: Enable DDC for DDIA

Browse source 
Enable DDC so that GOP can read the backlight brightness from EDID. This
avoids FSP repeatedly trying and failing to read it, and also stops the
backlight brightness not being restored correctly in Linux.

Change-Id: Ic05ec3cece911f61347bceb82e5798729dcaecfe
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86914
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2025-03-18 13:29:25 +00:00
commit 9c05e9900e
6 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
View file

@ -20,7 +20,7 @@ chip soc/intel/alderlake
device domain 0 on
device ref igpu on
register "ddi_ports_config" = "{
[DDI_PORT_A] = DDI_ENABLE_HPD,
[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
[DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
}"
end

2
src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
View file

@ -32,7 +32,7 @@ chip soc/intel/alderlake
register "gfx" = "GMA_DEFAULT_PANEL(0)"
register "ddi_portA_config" = "1"
register "ddi_ports_config" = "{
[DDI_PORT_A] = DDI_ENABLE_HPD,
[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
[DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
}"
end

2
src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb
View file

@ -52,7 +52,7 @@ chip soc/intel/alderlake
register "ddi_portA_config" = "1"
register "ddi_ports_config" = "{
[DDI_PORT_A] = DDI_ENABLE_HPD,
[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
[DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
}"
end

2
src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
View file

@ -34,7 +34,7 @@ chip soc/intel/alderlake
register "gfx" = "GMA_DEFAULT_PANEL(0)"
register "ddi_portA_config" = "1"
register "ddi_ports_config" = "{
[DDI_PORT_A] = DDI_ENABLE_HPD,
[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
[DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
}"
end

2
src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
View file

@ -33,7 +33,7 @@ chip soc/intel/alderlake
register "gfx" = "GMA_DEFAULT_PANEL(0)"
register "ddi_portA_config" = "1"
register "ddi_ports_config" = "{
[DDI_PORT_A] = DDI_ENABLE_HPD,
[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
[DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
}"
end

2
src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
View file

@ -62,7 +62,7 @@ chip soc/intel/alderlake
register "ddi_portA_config" = "1"
register "ddi_ports_config" = "{
[DDI_PORT_A] = DDI_ENABLE_HPD,
[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
[DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,
}"
end