From 9be383b855b57aedf156fdad3ffb3a20f96acf61 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Wed, 26 Feb 2025 17:22:21 +0100 Subject: [PATCH] drivers/lenovo/hybrid_graphics/chip: Use boolean when appropriate Change-Id: I1f456765eb60b8ad1e680255b50abad5dea8252c Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/86610 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/drivers/lenovo/hybrid_graphics/chip.h | 14 +++++++------- .../lenovo/t400/variants/t400/overridetree.cb | 12 ++++++------ src/mainboard/lenovo/t410/devicetree.cb | 14 +++++++------- src/mainboard/lenovo/t420/devicetree.cb | 10 +++++----- src/mainboard/lenovo/t420s/devicetree.cb | 10 +++++----- src/mainboard/lenovo/t430/devicetree.cb | 10 +++++----- src/mainboard/lenovo/t520/devicetree.cb | 10 +++++----- src/mainboard/lenovo/t530/devicetree.cb | 10 +++++----- 8 files changed, 45 insertions(+), 45 deletions(-) diff --git a/src/drivers/lenovo/hybrid_graphics/chip.h b/src/drivers/lenovo/hybrid_graphics/chip.h index b3ea2b6d2f..4a17138552 100644 --- a/src/drivers/lenovo/hybrid_graphics/chip.h +++ b/src/drivers/lenovo/hybrid_graphics/chip.h @@ -23,19 +23,19 @@ enum dgpu_detect_lvl { struct drivers_lenovo_hybrid_graphics_config { unsigned int detect_gpio; - unsigned int has_panel_hybrid_gpio; + bool has_panel_hybrid_gpio; unsigned int panel_hybrid_gpio; - unsigned int panel_integrated_lvl; + bool panel_integrated_lvl; - unsigned int has_backlight_gpio; + bool has_backlight_gpio; unsigned int backlight_gpio; - unsigned int backlight_integrated_lvl; + bool backlight_integrated_lvl; - unsigned int has_dgpu_power_gpio; + bool has_dgpu_power_gpio; unsigned int dgpu_power_gpio; - unsigned int dgpu_power_off_lvl; + bool dgpu_power_off_lvl; - unsigned int has_thinker1; + bool has_thinker1; }; #endif /* _LENOVO_HYBRID_GRAPHICS_CHIP_H_ */ diff --git a/src/mainboard/lenovo/t400/variants/t400/overridetree.cb b/src/mainboard/lenovo/t400/variants/t400/overridetree.cb index a1b4f9de3c..c3c3b082a5 100644 --- a/src/mainboard/lenovo/t400/variants/t400/overridetree.cb +++ b/src/mainboard/lenovo/t400/variants/t400/overridetree.cb @@ -8,17 +8,17 @@ chip northbridge/intel/gm45 register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "22" - register "panel_integrated_lvl" = "0" + register "panel_integrated_lvl" = "false" - register "has_backlight_gpio" = "1" + register "has_backlight_gpio" = "true" register "backlight_gpio" = "19" - register "backlight_integrated_lvl" = "0" + register "backlight_integrated_lvl" = "false" - register "has_dgpu_power_gpio" = "1" + register "has_dgpu_power_gpio" = "true" register "dgpu_power_gpio" = "49" - register "dgpu_power_off_lvl" = "0" + register "dgpu_power_off_lvl" = "false" register "has_thinker1" = "0" end diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb index 1ef7075ebf..9ba70d79e8 100644 --- a/src/mainboard/lenovo/t410/devicetree.cb +++ b/src/mainboard/lenovo/t410/devicetree.cb @@ -138,19 +138,19 @@ chip northbridge/intel/ironlake register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true" - register "has_backlight_gpio" = "1" + register "has_backlight_gpio" = "true" register "backlight_gpio" = "50" - register "backlight_integrated_lvl" = "0" + register "backlight_integrated_lvl" = "false" - register "has_dgpu_power_gpio" = "1" + register "has_dgpu_power_gpio" = "true" register "dgpu_power_gpio" = "49" - register "dgpu_power_off_lvl" = "0" + register "dgpu_power_off_lvl" = "false" - register "has_thinker1" = "1" + register "has_thinker1" = "true" end end device pci 1f.2 on # IDE/SATA diff --git a/src/mainboard/lenovo/t420/devicetree.cb b/src/mainboard/lenovo/t420/devicetree.cb index 65891f0c30..f5272fc701 100644 --- a/src/mainboard/lenovo/t420/devicetree.cb +++ b/src/mainboard/lenovo/t420/devicetree.cb @@ -158,14 +158,14 @@ chip northbridge/intel/sandybridge register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true" - register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false" - register "has_thinker1" = "1" + register "has_thinker1" = "true" end end # LPC Controller device ref sata1 on end # 6 port SATA AHCI Controller diff --git a/src/mainboard/lenovo/t420s/devicetree.cb b/src/mainboard/lenovo/t420s/devicetree.cb index b358885069..840e520fbb 100644 --- a/src/mainboard/lenovo/t420s/devicetree.cb +++ b/src/mainboard/lenovo/t420s/devicetree.cb @@ -150,14 +150,14 @@ chip northbridge/intel/sandybridge register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true" - register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false" - register "has_thinker1" = "1" + register "has_thinker1" = "true" end end # LPC Controller device ref sata1 on end # 6 port SATA AHCI Controller diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 89dcf97fea..9a0db4dd85 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -131,14 +131,14 @@ chip northbridge/intel/sandybridge register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true" - register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false" - register "has_thinker1" = "1" + register "has_thinker1" = "true" end chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb index c404df2d2d..7102df0b9d 100644 --- a/src/mainboard/lenovo/t520/devicetree.cb +++ b/src/mainboard/lenovo/t520/devicetree.cb @@ -146,14 +146,14 @@ chip northbridge/intel/sandybridge register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true" - register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false" - register "has_thinker1" = "1" + register "has_thinker1" = "true" end end device ref sata1 on end diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index 305a47efff..362e0a69e9 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -126,14 +126,14 @@ chip northbridge/intel/sandybridge register "detect_gpio" = "21" - register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true" - register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false" - register "has_thinker1" = "1" + register "has_thinker1" = "true" end end device ref sata1 on end