From 9b308f4d54c054103a8e077308537734a17079fb Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 21 Nov 2024 16:00:07 +0100 Subject: [PATCH] soc/amd/common/psp/psp_smi: report errors in 'handle_psp_command' To see if things went wrong in the 'handle_psp_command' function, print the status code in case it's not MBOX_PSP_SUCCESS. Change-Id: I8c02e8e29ab5619282e5b864a8cea6f0703f6ef2 Signed-off-by: Felix Held Reviewed-on: https://review.coreboot.org/c/coreboot/+/85238 Reviewed-by: Marshall Dawson Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/psp/psp_smi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/soc/amd/common/block/psp/psp_smi.c b/src/soc/amd/common/block/psp/psp_smi.c index 5a1a4b9e46..762c8ee9c1 100644 --- a/src/soc/amd/common/block/psp/psp_smi.c +++ b/src/soc/amd/common/block/psp/psp_smi.c @@ -173,6 +173,9 @@ out: if (status == MBOX_PSP_SUCCESS && rd_bios_mbox_checksum_en()) wr_bios_mbox_checksum(calc_psp_buffer_checksum8()); + + if (status != MBOX_PSP_SUCCESS) + printk(BIOS_ERR, "PSP: SMI processing error. staus code %#x\n", status); } /* TODO: check if all wbinvd() calls are necessary */