erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/poppy: Correct channel count for DMIC

Browse source 
These boards only have 2 DMIC physically connected, and attempting to
record from 4 channels vs 2 results in a large amount of background
noise which drowns out the recording. Selecting the 2 channel DMIC
shows audio on both channels and no noise.

TEST=build/boot poppy variants, test built-in mic under Windows
and Linux.

Change-Id: I30d97fa1a25e8cefe05cedac5176bb74dad7f318
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88082
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2025-06-12 13:14:20 -05:00 • committed by Sean Rhodes
commit 9accaa7238
7 changed files with 20 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/mainboard/google/poppy/Kconfig
View file

@ -138,37 +138,36 @@ config DRIVER_TPM_SPI_BUS
config INCLUDE_NHLT_BLOBS
bool "Include blobs for audio."
select NHLT_DMIC_2CH
select NHLT_DMIC_4CH
select NHLT_MAX98927
select NHLT_RT5663
config INCLUDE_NHLT_BLOBS_ATLAS
bool "Include blobs for atlas audio."
select NHLT_DA7219
select NHLT_DMIC_4CH
select NHLT_DMIC_2CH
select NHLT_MAX98373
config INCLUDE_NHLT_BLOBS_NAUTILUS
bool "Include blobs for nautilus audio."
select NHLT_DA7219
select NHLT_DMIC_4CH
select NHLT_DMIC_2CH
select NHLT_MAX98357
config INCLUDE_NHLT_BLOBS_NAMI
bool "Include blobs for nami audio."
select NHLT_DA7219
select NHLT_DMIC_4CH
select NHLT_DMIC_2CH
select NHLT_MAX98357
config INCLUDE_NHLT_BLOBS_NOCTURNE
bool "Include blobs for nocturne audio."
select NHLT_DMIC_4CH
select NHLT_DMIC_2CH
select NHLT_MAX98373
config INCLUDE_NHLT_BLOBS_RAMMUS
bool "Include blobs for rammus audio."
select NHLT_DA7219
select NHLT_DMIC_4CH
select NHLT_DMIC_2CH
select NHLT_MAX98927
config MAINBOARD_DIR

6
src/mainboard/google/poppy/variants/atlas/nhlt.c
View file

@ -7,9 +7,9 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
/* 4 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 4))
printk(BIOS_ERR, "Couldn't add 4CH DMIC arrays.\n");
/* 2 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 2))
printk(BIOS_ERR, "Couldn't add 2CH DMIC arrays.\n");
/* Dialog DA7219 Headset codec. */
if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))

4
src/mainboard/google/poppy/variants/baseboard/nhlt.c
View file

@ -11,10 +11,6 @@ void __weak variant_nhlt_init(struct nhlt *nhlt)
if (nhlt_soc_add_dmic_array(nhlt, 2))
printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
/* 4 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 4))
printk(BIOS_ERR, "Couldn't add 4CH DMIC arrays.\n");
/* Maxim MAX98927 Smart Amps for left and right channel */
/* Render time_slot is 0 and feedback time_slot is 2 */
if (nhlt_soc_add_max98927(nhlt, AUDIO_LINK_SSP0, 0, 2))

6
src/mainboard/google/poppy/variants/nami/nhlt.c
View file

@ -7,9 +7,9 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
/* 4 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 4))
printk(BIOS_ERR, "Couldn't add 4CH DMIC array.\n");
/* 2 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 2))
printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
/* Dialog DA7219 Headset codec. */
if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))

6
src/mainboard/google/poppy/variants/nautilus/nhlt.c
View file

@ -7,9 +7,9 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
/* 4 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 4))
printk(BIOS_ERR, "Couldn't add 4CH DMIC array.\n");
/* 2 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 2))
printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
/* Dialog DA7219 Headset codec. */
if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))

6
src/mainboard/google/poppy/variants/nocturne/nhlt.c
View file

@ -7,9 +7,9 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
/* 4 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 4))
printk(BIOS_ERR, "Couldn't add 4CH DMIC array.\n");
/* 2 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 2))
printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
/* MAXIM Smart Amps for left and right speakers. */
/* Render time_slot is 0 and feedback time_slot is 2 */

6
src/mainboard/google/poppy/variants/rammus/nhlt.c
View file

@ -7,9 +7,9 @@
void variant_nhlt_init(struct nhlt *nhlt)
{
/* 4 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 4))
printk(BIOS_ERR, "Couldn't add 4CH DMIC array.\n");
/* 2 Channel DMIC array. */
if (nhlt_soc_add_dmic_array(nhlt, 2))
printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n");
/* Dialog DA7219 Headset codec. */
if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))