From 99d67bae637b935573bfbeb98598ba1e8d5d285f Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Mon, 1 Dec 2025 20:31:43 -0600 Subject: [PATCH] mb/google/glados: Add CFR option menu support Add CFR option menu support when using edk2 payload and SMMSTORE. Include relevant items from Skylake SoC, Intel common, and ChromeEC. TEST=build/boot google/glados (chell), verify CFR option functionality. Change-Id: Ie124d69e979c7d0ca8dd119046412cb637eb04da Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90316 Tested-by: build bot (Jenkins) Reviewed-by: Jason Glenesk --- src/mainboard/google/glados/Kconfig | 1 + src/mainboard/google/glados/Makefile.mk | 2 +- src/mainboard/google/glados/cfr.c | 46 +++++++++++++++++++++++++ 3 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 src/mainboard/google/glados/cfr.c diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 779dc48bac..811a03deac 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -5,6 +5,7 @@ config BOARD_GOOGLE_BASEBOARD_GLADOS select BOARD_ROMSIZE_KB_16384 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_NAU8825 + select DRIVERS_OPTION_CFR_ENABLED if PAYLOAD_EDK2 && SMMSTORE select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_LPC diff --git a/src/mainboard/google/glados/Makefile.mk b/src/mainboard/google/glados/Makefile.mk index 9fd41f89a7..dc6e3393d7 100644 --- a/src/mainboard/google/glados/Makefile.mk +++ b/src/mainboard/google/glados/Makefile.mk @@ -12,7 +12,7 @@ romstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c - +ramstage-$(CONFIG_DRIVERS_OPTION_CFR) += cfr.c ramstage-y += mainboard.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/google/glados/cfr.c b/src/mainboard/google/glados/cfr.c new file mode 100644 index 0000000000..2025ad32ee --- /dev/null +++ b/src/mainboard/google/glados/cfr.c @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include +#include +#include +#include +#include + +static struct sm_obj_form system = { + .ui_name = "System", + .obj_list = (const struct sm_object *[]) { + &hyper_threading, + &igd_dvmt, + &igd_aperture, + &legacy_8254_timer, + &me_state, + &me_state_counter, + &pciexp_aspm, + &pciexp_clk_pm, + &pciexp_l1ss, + &pciexp_speed, + &s0ix_enable, + &vtd, + NULL + }, +}; + +static struct sm_obj_form ec = { + .ui_name = "ChromeEC Embedded Controller", + .obj_list = (const struct sm_object *[]) { + &auto_fan_control, + &ec_kb_backlight, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &system, + &ec, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +}