From 99af85ad364318839111e33423d2ec536eddc34f Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Wed, 21 May 2025 17:52:46 -0500 Subject: [PATCH] mb/google/puff: Add VBTs for Moonbuggy and Scout variants These variants were missing VBTs necessary for display init, so add them. VBT files taken from the stock firmware images: coreboot-Google_Moonbuggy.13324.803.0.bin coreboot-Google_Scout.13324.645.0.bin Since all variants now have VBTs, move the selection of INTEL_GMA_HAVE_VBT to the baseboard. TEST=build/boot various puff variants, including scout. Change-Id: I2bb06894fc4df358cc38a4627de9f95289c2c5e0 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/87779 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/puff/Kconfig | 12 +----------- .../google/puff/variants/moonbuggy/data.vbt | Bin 0 -> 4608 bytes .../google/puff/variants/scout/data.vbt | Bin 0 -> 4608 bytes 3 files changed, 1 insertion(+), 11 deletions(-) create mode 100644 src/mainboard/google/puff/variants/moonbuggy/data.vbt create mode 100644 src/mainboard/google/puff/variants/scout/data.vbt diff --git a/src/mainboard/google/puff/Kconfig b/src/mainboard/google/puff/Kconfig index c35cf6b188..2ec9d996b9 100644 --- a/src/mainboard/google/puff/Kconfig +++ b/src/mainboard/google/puff/Kconfig @@ -24,6 +24,7 @@ config BOARD_GOOGLE_BASEBOARD_PUFF select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_TPM2 @@ -41,50 +42,40 @@ config BOARD_GOOGLE_BASEBOARD_PUFF config BOARD_GOOGLE_AMBASSADOR select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DOOLY select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT select SYSTEM_TYPE_ALL_IN_ONE config BOARD_GOOGLE_DUFFY_LEGACY select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_DUFFY select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_FAFFY select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_GENESIS select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KAISA_LEGACY select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_KAISA select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_MOONBUGGY select BOARD_GOOGLE_BASEBOARD_PUFF config BOARD_GOOGLE_NOIBAT select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_PUFF select BOARD_GOOGLE_BASEBOARD_PUFF select BOARD_ROMSIZE_KB_32768 - select INTEL_GMA_HAVE_VBT config BOARD_GOOGLE_SCOUT select BOARD_GOOGLE_BASEBOARD_PUFF @@ -92,7 +83,6 @@ config BOARD_GOOGLE_SCOUT config BOARD_GOOGLE_WYVERN select BOARD_GOOGLE_BASEBOARD_PUFF - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_BASEBOARD_PUFF diff --git a/src/mainboard/google/puff/variants/moonbuggy/data.vbt b/src/mainboard/google/puff/variants/moonbuggy/data.vbt new file mode 100644 index 0000000000000000000000000000000000000000..a25cfde012547b8e89c9fb1d88248a431e65ab28 GIT binary patch literal 4608 zcmeHKUu;ul6hF6j{rBB_yY`OAR_8qY3ABTa+W{5l7H`)MS5|1Zj%7sS3bf!tVRL_U z7|d$2C=W{dpau=fUWm$z_+)&;Hxd&iF~KJzCMGDpNaV$U)N{Xk*Rl~@!GK~oz2`gU zJNMk*J?Hy(Pgf6i4Pd%=S0d8ejTU7=gHyieslAoD;>q-IEHV%o?n)%1z4#M60+YTQ zmjSYZ&>)92EfhaAnac^FQSus=7E8-FR6ZB>{7au!@Q0)SwL+Or_QpKSm&06K3;DPLrvi^w(a zz5oOLdz@+7%3TY2_|5DWtF z2pSx7H$hSiz!A{~uZvrtx#k>bZiKYk3;T!<6Mt)G@ICP*;w!}0i0uvrwZsj?tB6~O zpCFD9_Y&_U9wr_kc1*$blC1zvo_RsAq|cP#t$|}fD4ekDCoH@BH=1-JW=YAC+*n0Z zDmk5Sqx5w>luE8nBLbZeC~YBTA@x`?!KEmsto{H=W2}a(eyQZnP}jy6$h~UWS5V$` zrP6$U52_~D!8Y1UqN`)Jk>|1#pmb6ZVH%jPvXNDJeo=C#WgmjWZ>H|-m>+`0^54AU zH%^8}W%0a|!FlIZ;b`4|Q!~cQyTs2NS6X1!v0(Newhu?(&PJfI2QIh^MZEZ!*Oggm zKHGG6mdBr?HEVOx!J&ikO_iYs0#FYzSPjb{11Vl#x%fG}Ajs-Wh)~Nv?F*h=&W_^5%FrjNt0dMUVOmmi5*wB99ZCI2VxLL) zouvLEvEL{k20{lFSGUhXYlh=}py}FJT{#AN(9q>+yT2-gY3%cRb?;3G zLeYK)2p?~lzS!qqqYoXg#2^$M96@)SsUn7+r*&=5nKoTNTS0J`RgyetuVy6otr$Gr z2Tj`6qBR%BNEZ3`l|rdz9FDXW=Q92#T|;XwXf|t#yo!|z&T6ss&a5JYW+Qh1 zLa-NkEhEp_XRBBb?+543_sy=0_ zyCyk;Vj|eFiYzYsVJ?NsHCc;RvMADiq!Or-;Aoj14Aq>B U`9ClBU2ZgvE#m;7U3L%YFX-Ob9{>OV literal 0 HcmV?d00001 diff --git a/src/mainboard/google/puff/variants/scout/data.vbt b/src/mainboard/google/puff/variants/scout/data.vbt new file mode 100644 index 0000000000000000000000000000000000000000..ca387a5a70ae53c9bc579a013b549d21da22f3ca GIT binary patch literal 4608 zcmeHKUu;ul6hF6j{rBB_yW2Y=Tg7?!6KDq;w*xB95pUNHS5|1Zj%7rX6==apVRL_U z7|d$2C=W{dpau=fUWm$z_+)&;Hxd&in&6WW6B86)B=TZF>bc*&TgM2lU{Eof-t(RF zoqO)@JLmh~Rs9`(nCae?jCOaTO*zovl>a#@Z>5ezDl-_5_C*IflBrlX{s<4jxc|mw zfSe#S$YEU%Ck~D03&GwH!6tG0@SdSUetkSYc3^yX1kx?UGE{)jm$l=kU{m+hLFc!jAYNMHh@{ln$ zJUY^X(Lw=xO`kFB&5z|rU&!ZL6lQ{)1y79tAUL7+EC}#ND?kl^!Anx+91vC|2Lu&2^2rXi}k+2%o1+*0Irdn>$WxGjc-6Xupjhp`ILZnQtzeKH?8F3+)1mF{N zIOc7Hlo*5~q61zPH$zj+Inccb8LtZahz}Eg<7Dt1@g?Fb#Mg+OE(W#44a6&nn~5JI zjuLkh?<5{19wK&4!1c1D2yWhdQLv@olAzYWu@Dqb*!B~)-TNyIIuWy_WJ_+Wq9~W$ zZn#nYvL4E1&lWQRgAgcfA#Nje*)qwcD5mXtA4#*X2JCvd?9Ecu!6(SQD%lq>x9G~{ z+5GNTO|FA&v=T*6`}8uN%T9puNkxQ7VE)QN*5uhq$(@$G53Ycfy1RY03l_?M^G(3q z86K9!^KJ&`-B*R9b^lGx>@#(dpVhB4!R&3psy`?n^uV3+$U>UmuRQiaJul4aOo&j+kM?MGw1U|OF z2ymLnGKSs+aX-U1n0At}j~IT%v>zDzg`r>4R!Xc{!i=QlB{nSKTaxyH#6FSmTS@y_ zV!uh)AZu%7wn@gPW$mEMUX<}YS^HRKpUL>WtX+}WH5r#H+6IMfQE;!KO(<+i!BdL% zslq;2@RFkat}xMuA)oeyk9GR+fKPkb$6oU(O`5alxF{6;K7K#(jLNh>4LD>juL>$j zXYCp~32z;k$dq7h0WyjMj>QpXY7xQ%%P?46Vs%MlWXd`eX}oC5UmPLV07ev6>-9$? z7D9bwO0=$36eiS|2<>#ax_uUU6CCdW-Oxws=3<}^Oop_g;GsF9BC=dWCM+cj`mp4Xx5bYEmkhNtH~nRUYr>@vyu>+%-jJ8!CB&W z8F|JzUB!HOH#Bp;XL^O6erM?%f(ZNyEgP4L$wBD_Rq^d QE;pFlmbn4YD!YgDC;WEU9{>OV literal 0 HcmV?d00001