From 9992321447709dc922e90610f239604fe5064c2d Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 8 Jan 2016 17:22:09 -0800 Subject: [PATCH] UPSTREAM: soc/intel/broadwell/lpc.c: don't zeroize existing gnvs table The gnvs table only needs to be zeroized after init; zeroizing an existing/populated table renders all I2C devices completely non-functional. TEST: boot Linux and observe all I2C devices functional BUG=None BRANCH=None TEST=None Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/17828 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Change-Id: Id149ad645dfe5ed999a65d10e786e17585abc477 Reviewed-on: https://chromium-review.googlesource.com/420834 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Furquan Shaikh --- src/soc/intel/broadwell/lpc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c index 850583b763..e4db498e30 100644 --- a/src/soc/intel/broadwell/lpc.c +++ b/src/soc/intel/broadwell/lpc.c @@ -599,7 +599,6 @@ static void southcluster_inject_dsdt(device_t device) } if (gnvs) { - memset(gnvs, 0, sizeof(*gnvs)); acpi_create_gnvs(gnvs); acpi_save_gnvs((unsigned long)gnvs); /* And tell SMI about it */