From 96da2e3771bb6aa511c444183e46ddae6c3b1b70 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 26 Jan 2017 10:51:43 -0700 Subject: [PATCH] UPSTREAM: Makefile: Just error out if no .config exists Currently coreboot runs the 'config' command if no .config file exists. This isn't what anyone wants, and is particularly frustrating for tools that automate the build, where the build just hangs waiting for input. Instead, just show an error message and then exit the build. BUG=none BRANCH=none TEST=none Change-Id: I8770f1f9be6990ca190a9fea78f340e0574e46bd Signed-off-by: Patrick Georgi Original-Commit-Id: 20aa043b449dc68379f4b64c257a066e17fda4b8 Original-Change-Id: If9e0c2c26f8273814518589a2f94c5b00fc4cefe Original-Signed-off-by: Martin Roth Original-Reviewed-on: https://review.coreboot.org/18245 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Nico Huber Reviewed-on: https://chromium-review.googlesource.com/433982 --- Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 2c87feb7a7..29730302b0 100644 --- a/Makefile +++ b/Makefile @@ -123,8 +123,11 @@ endif ifeq ($(NOCOMPILE),1) include $(TOPLEVEL)/Makefile.inc include $(TOPLEVEL)/payloads/Makefile.inc -real-all: config - +real-all: + @echo "Error: Expected config file ($(DOTCONFIG)) not present." >&2 + @echo "Please specify a config file or run 'make menuconfig' to" >&2 + @echo "generate a new config file." >&2 + @exit 1 else include $(DOTCONFIG)