From 958bc5cdffa6b0a4e4824bad02861f9907636eb1 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 23 Feb 2026 22:13:16 +0100 Subject: [PATCH] nb/intel/broadwell: Move `size_of_dnvs()` to southbridge Device NVS is only used in southbridge code. This change is non-reproducible. Change-Id: I60ce9a80d6e3e0ce0c13037d4caae473d3d092a9 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/91402 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/northbridge/intel/broadwell/acpi.c | 7 ------- src/southbridge/intel/wildcatpoint/Makefile.mk | 1 + src/southbridge/intel/wildcatpoint/acpi.c | 10 ++++++++++ 3 files changed, 11 insertions(+), 7 deletions(-) create mode 100644 src/southbridge/intel/wildcatpoint/acpi.c diff --git a/src/northbridge/intel/broadwell/acpi.c b/src/northbridge/intel/broadwell/acpi.c index 691bcdec31..453c77a235 100644 --- a/src/northbridge/intel/broadwell/acpi.c +++ b/src/northbridge/intel/broadwell/acpi.c @@ -1,13 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include -#include #include #include #include #include #include -#include #include #include #include @@ -87,8 +85,3 @@ unsigned long northbridge_write_acpi_tables(const struct device *const dev, return current; } - -size_t size_of_dnvs(void) -{ - return sizeof(struct device_nvs); -} diff --git a/src/southbridge/intel/wildcatpoint/Makefile.mk b/src/southbridge/intel/wildcatpoint/Makefile.mk index ec54db4632..59f48805ce 100644 --- a/src/southbridge/intel/wildcatpoint/Makefile.mk +++ b/src/southbridge/intel/wildcatpoint/Makefile.mk @@ -4,6 +4,7 @@ ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_WILDCATPOINT),y) bootblock-y += bootblock.c +ramstage-y += acpi.c ramstage-y += adsp.c romstage-y += early_pch.c ramstage-$(CONFIG_ELOG) += elog.c diff --git a/src/southbridge/intel/wildcatpoint/acpi.c b/src/southbridge/intel/wildcatpoint/acpi.c new file mode 100644 index 0000000000..091bb50319 --- /dev/null +++ b/src/southbridge/intel/wildcatpoint/acpi.c @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include +#include +#include + +size_t size_of_dnvs(void) +{ + return sizeof(struct device_nvs); +}